fix(import): preserve preformatted text node newlines - #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
base.textnodes in both publisher output and the editor canvas.<pre><code>imports and document the whitespace-preservation contract.Why
Super Import correctly stored significant newlines inside
<pre>, but the shared text renderer published those no-wrapper newline nodes as<br>elements. Typewriter scripts that snapshotcode.childNodesthen saw empty element segments; reading past those segments produced the literal textundefinedthroughout imported terminal/code animations.Impact
Imported preformatted blocks retain the source DOM text-node shape, so runtime scripts can safely inspect and animate them. Existing imported sites only need to be republished after upgrading; no re-import is required.
Verification
bun test— 6,281 passedbun run lintbun run buildbun run doctor— completed with the repository's existing warning baseline