[DoNotMerge] Models discrepancies. This PR attemp to document a discussion.#2
Closed
ipa-nhg wants to merge 1 commit intoCoreSenseEU:mainfrom
Closed
[DoNotMerge] Models discrepancies. This PR attemp to document a discussion.#2ipa-nhg wants to merge 1 commit intoCoreSenseEU:mainfrom
ipa-nhg wants to merge 1 commit intoCoreSenseEU:mainfrom
Conversation
…l implementation from Fhg IPA, commit made to open the discussion.
Member
Author
|
@fmrico I have created this PR to document the conclusions of our meeting on Tuesday. If I have forgotten something or did not understand your opinion. |
ipa-nhg
added a commit
to ipa320/RosTooling
that referenced
this pull request
May 30, 2023
Member
|
I should check this in #3 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the Readme model example to follow the current DSL implementation from Fhg IPA. This commit was only made to open the discussion. Once everything is clarified, the branch can be deleted.
To Change from IPA model:
To Change from URJC model
For a complete implementation of the qos part, here is the full DSL implementation: https://github.com/ipa320/ros-model/blob/main/plugins/de.fraunhofer.ipa.ros2.xtext/src/de/fraunhofer/ipa/ros2/Ros2.xtext#L30-L37