Skip to content

[DoNotMerge] Models discrepancies. This PR attemp to document a discussion.#2

Closed
ipa-nhg wants to merge 1 commit intoCoreSenseEU:mainfrom
ipa-nhg:ModelsDiscrepanciesDiscussion
Closed

[DoNotMerge] Models discrepancies. This PR attemp to document a discussion.#2
ipa-nhg wants to merge 1 commit intoCoreSenseEU:mainfrom
ipa-nhg:ModelsDiscrepanciesDiscussion

Conversation

@ipa-nhg
Copy link
Copy Markdown
Member

@ipa-nhg ipa-nhg commented May 26, 2023

‼️ ‼️ DO NOT MERGE ‼️ ‼️

Modify the Readme model example to follow the current DSL implementation from Fhg IPA. This commit was only made to open the discussion. Once everything is clarified, the branch can be deleted.

To Change from IPA model:

To Change from URJC model

  • FromGitRepo -> fromGitRepo ( I think this does not require code changes)
  • Extension of the file (.ros2)
  • Put the system description in a separate file, with the .rossystem extension
  • Change the qos keywords:
    • qos_profile -> profile
      • "sensor_qos" -> sensor_qos
    • qos_reliability -> reliability
      • "reliable" -> reliable
    • qos_history_depth -> deph

For a complete implementation of the qos part, here is the full DSL implementation: https://github.com/ipa320/ros-model/blob/main/plugins/de.fraunhofer.ipa.ros2.xtext/src/de/fraunhofer/ipa/ros2/Ros2.xtext#L30-L37

…l implementation from Fhg IPA, commit made to open the discussion.
@ipa-nhg ipa-nhg marked this pull request as draft May 26, 2023 12:10
@ipa-nhg
Copy link
Copy Markdown
Member Author

ipa-nhg commented May 26, 2023

@fmrico I have created this PR to document the conclusions of our meeting on Tuesday. If I have forgotten something or did not understand your opinion.

ipa-nhg added a commit to ipa320/RosTooling that referenced this pull request May 30, 2023
@fmrico
Copy link
Copy Markdown
Member

fmrico commented Aug 3, 2023

I should check this in #3 🤔

@fmrico fmrico deleted the branch CoreSenseEU:main August 6, 2024 06:39
@fmrico fmrico closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants