Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

The deriveChild function in src/lib/crypto/evm.ts was not cleaning up the pubKey intermediate value during non-hardened key derivation, potentially leaking cryptographic material in memory.

Changes:

  • Track pubKey as nullable variable scoped to try/finally block
  • Zero pubKey in finally clause using secureZero()
  • Zero old pubKey before reassignment in retry loop iterations

This matches the pattern established in src/lib/crypto/bitcoin.ts (commit 76e8856).

// Before: pubKey created but never cleaned up
} else {
  const pubKey = secp256k1.getPublicKey(parentKey, true);
  data.set(pubKey, 0);
}

// After: pubKey tracked and securely zeroed
let pubKey: Uint8Array | null = null;
try {
  // ...
  } else {
    if (pubKey !== null) secureZero(pubKey);  // Clean on retry
    pubKey = secp256k1.getPublicKey(parentKey, true);
    data.set(pubKey, 0);
  }
} finally {
  if (pubKey !== null) secureZero(pubKey);  // Clean on exit
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2026

Deploying vidulum-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e3b710
Status: ✅  Deploy successful!
Preview URL: https://8052453a.vidulum-app.pages.dev
Branch Preview URL: https://copilot-sub-pr-52-another-on.vidulum-app.pages.dev

View logs

Copilot AI changed the title [WIP] Address feedback on feature changes and improvements Fix memory leak in EVM BIP32 child key derivation Feb 3, 2026
Copilot AI requested a review from Corey-Code February 3, 2026 03:24
@Corey-Code Corey-Code marked this pull request as ready for review February 3, 2026 03:43
@Corey-Code Corey-Code merged commit 8533d63 into feature/changes-and-improvements Feb 3, 2026
1 check passed
@Corey-Code Corey-Code deleted the copilot/sub-pr-52-another-one branch February 3, 2026 03:44
Corey-Code added a commit that referenced this pull request Feb 3, 2026
* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) (#50)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app

* Update src/popup/components/MoonPaySDKWidget.tsx



* Update Withdraw.tsx



* Fix MoonPay extension documentation to reflect new tab implementation (#48)

* Initial plan

* Update MoonPayWidget documentation to reflect new tab approach



---------




* Fix MoonPay widget documentation to reflect new tab implementation (#49)

* Initial plan

* Update MoonPay integration documentation to reflect new tab behavior



---------




---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

* feat: add BIP32 and BIP84 derivation tests for Bitcoin addresses

- Implemented BIP32 derivation logic in test-bip32.cjs for generating child keys and addresses.
- Added BIP84 path derivation for native SegWit addresses in test-bip32.cjs.
- Created test-keplr-path.cjs to validate Keplr-compatible derivation paths for Bitcoin.
- Introduced comprehensive tests for UTXO transactions in transaction.test.ts, covering fee estimation, transaction building, and error handling.
- Enhanced crypto tests to validate Bitcoin key derivation and address generation in keyring.test.ts.
- Updated chainRegistry tests to mock cosmos-registry module for better isolation.

* feat: implement IBC transfer functionality and modal in the dashboard

* Add fee validation for sweepAll transactions to prevent excessive fees (#53)

* Fix memory safety in deriveBitcoinKeyPairFromSeed key cleanup (#55)

* Secure pubKey cleanup in BIP32 child key derivation (#54)

* Update transaction.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update bitcoin.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update encrypted-storage.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update transaction.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update walletStore.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update ibc-connections.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Dashboard.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update chainRegistry.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update transaction.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Simplify secureZero function in evm.ts to remove ineffective random overwrite (#56)

* Add BIP32 hardened derivation indicator documentation (#57)

* Fix memory leak in EVM BIP32 child key derivation (#58)

* Use actual UTXO count for Bitcoin max amount fee estimation (#59)

* Remove forceReDerive parameter from address derivation (#60)

* Refactor IBC connections to use pre-bundled data; remove runtime fetching and caching logic

- Updated `fetchIBCConnections` to utilize `getIBCChannelsForChainId` for fetching IBC connections.
- Removed caching mechanism and related functions for IBC connections.
- Re-exported `IBCChannel` type for backward compatibility.
- Cleaned up code and comments for clarity.
- Updated Cosmos registry file with new formatting and removed unnecessary comments.

* Optimize address caching with two-level structure to persist across network switches (#63)

* Initial plan

* Implement two-level cache for Bitcoin and EVM addresses

- Change cache structure from Map<cosmosAddress, address> to Map<cosmosAddress, Map<networkId, address>>
- Addresses now persist across network switches
- Only clear display state on network change, not the entire cache
- Check cache before re-deriving addresses to avoid redundant work
- Improves efficiency for users switching between networks

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Fix infinite loop in cache dependency arrays

- Remove cache state from useEffect dependencies to prevent infinite loops
- Use functional state updates to access previous cache state
- Separate cache checking and updating into distinct phases
- Maintains cache persistence while avoiding re-render cycles

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Refactor cache to use useRef instead of setState for reads

- Replace useState cache with useRef to avoid anti-pattern
- Use trigger state to force re-renders when cache updates
- Read directly from ref without needing setState callbacks
- Cleaner code that follows React best practices

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Add runtime Buffer polyfill checks to prevent initialization order issues (#62)

* Initial plan

* Add runtime Buffer availability checks to prevent initialization order issues

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Refactor: Extract ensureBuffer to shared utility module

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Optimize Buffer checks: call ensureBuffer once at module level

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Add documentation explaining defensive Buffer check in ensureBuffer

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Corey-Code added a commit that referenced this pull request Feb 3, 2026
* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app

* Update src/popup/components/MoonPaySDKWidget.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Withdraw.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix MoonPay extension documentation to reflect new tab implementation (#48)

* Initial plan

* Update MoonPayWidget documentation to reflect new tab approach

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Fix MoonPay widget documentation to reflect new tab implementation (#49)

* Initial plan

* Update MoonPay integration documentation to reflect new tab behavior

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

* Feature/changes and improvements (#52)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) (#50)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app

* Update src/popup/components/MoonPaySDKWidget.tsx



* Update Withdraw.tsx



* Fix MoonPay extension documentation to reflect new tab implementation (#48)

* Initial plan

* Update MoonPayWidget documentation to reflect new tab approach



---------




* Fix MoonPay widget documentation to reflect new tab implementation (#49)

* Initial plan

* Update MoonPay integration documentation to reflect new tab behavior



---------




---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

* feat: add BIP32 and BIP84 derivation tests for Bitcoin addresses

- Implemented BIP32 derivation logic in test-bip32.cjs for generating child keys and addresses.
- Added BIP84 path derivation for native SegWit addresses in test-bip32.cjs.
- Created test-keplr-path.cjs to validate Keplr-compatible derivation paths for Bitcoin.
- Introduced comprehensive tests for UTXO transactions in transaction.test.ts, covering fee estimation, transaction building, and error handling.
- Enhanced crypto tests to validate Bitcoin key derivation and address generation in keyring.test.ts.
- Updated chainRegistry tests to mock cosmos-registry module for better isolation.

* feat: implement IBC transfer functionality and modal in the dashboard

* Add fee validation for sweepAll transactions to prevent excessive fees (#53)

* Fix memory safety in deriveBitcoinKeyPairFromSeed key cleanup (#55)

* Secure pubKey cleanup in BIP32 child key derivation (#54)

* Update transaction.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update bitcoin.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update encrypted-storage.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update transaction.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update walletStore.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update ibc-connections.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update IBCTransferModal.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Dashboard.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update chainRegistry.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update transaction.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Simplify secureZero function in evm.ts to remove ineffective random overwrite (#56)

* Add BIP32 hardened derivation indicator documentation (#57)

* Fix memory leak in EVM BIP32 child key derivation (#58)

* Use actual UTXO count for Bitcoin max amount fee estimation (#59)

* Remove forceReDerive parameter from address derivation (#60)

* Refactor IBC connections to use pre-bundled data; remove runtime fetching and caching logic

- Updated `fetchIBCConnections` to utilize `getIBCChannelsForChainId` for fetching IBC connections.
- Removed caching mechanism and related functions for IBC connections.
- Re-exported `IBCChannel` type for backward compatibility.
- Cleaned up code and comments for clarity.
- Updated Cosmos registry file with new formatting and removed unnecessary comments.

* Optimize address caching with two-level structure to persist across network switches (#63)

* Initial plan

* Implement two-level cache for Bitcoin and EVM addresses

- Change cache structure from Map<cosmosAddress, address> to Map<cosmosAddress, Map<networkId, address>>
- Addresses now persist across network switches
- Only clear display state on network change, not the entire cache
- Check cache before re-deriving addresses to avoid redundant work
- Improves efficiency for users switching between networks

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Fix infinite loop in cache dependency arrays

- Remove cache state from useEffect dependencies to prevent infinite loops
- Use functional state updates to access previous cache state
- Separate cache checking and updating into distinct phases
- Maintains cache persistence while avoiding re-render cycles

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Refactor cache to use useRef instead of setState for reads

- Replace useState cache with useRef to avoid anti-pattern
- Use trigger state to force re-renders when cache updates
- Read directly from ref without needing setState callbacks
- Cleaner code that follows React best practices

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Add runtime Buffer polyfill checks to prevent initialization order issues (#62)

* Initial plan

* Add runtime Buffer availability checks to prevent initialization order issues

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Refactor: Extract ensureBuffer to shared utility module

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Optimize Buffer checks: call ensureBuffer once at module level

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

* Add documentation explaining defensive Buffer check in ensureBuffer

Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

* Add comprehensive tests for Solana and asset management functionality (#64)

* Add comprehensive tests for Solana and asset management functionality

- Introduced tests for known ERC20 and SPL tokens, validating structure, uniqueness, and common tokens.
- Implemented tests for Solana cryptography, including key derivation, address generation, and validation.
- Enhanced network registry tests to include SVM networks and their configurations.
- Developed extensive tests for Solana RPC client, covering balance retrieval, token balances, transaction handling, and error management.

* Update solana.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update knownAssets tests for BSC and Polygon token support (#65)

* Implement proper base58 decoding and 32-byte validation for Solana addresses (#66)

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Corey-Code added a commit that referenced this pull request Feb 3, 2026
* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app

* Update src/popup/components/MoonPaySDKWidget.tsx



* Update Withdraw.tsx



* Fix MoonPay extension documentation to reflect new tab implementation (#48)

* Initial plan

* Update MoonPayWidget documentation to reflect new tab approach



---------




* Fix MoonPay widget documentation to reflect new tab implementation (#49)

* Initial plan

* Update MoonPay integration documentation to reflect new tab behavior



---------




---------




* Feature/changes and improvements (#52)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) (#50)

* Feature - Integrate MoonPay SDK for buy/sell functionality in web app

* Update src/popup/components/MoonPaySDKWidget.tsx



* Update Withdraw.tsx



* Fix MoonPay extension documentation to reflect new tab implementation (#48)

* Initial plan

* Update MoonPayWidget documentation to reflect new tab approach



---------




* Fix MoonPay widget documentation to reflect new tab implementation (#49)

* Initial plan

* Update MoonPay integration documentation to reflect new tab behavior



---------




---------




* feat: add BIP32 and BIP84 derivation tests for Bitcoin addresses

- Implemented BIP32 derivation logic in test-bip32.cjs for generating child keys and addresses.
- Added BIP84 path derivation for native SegWit addresses in test-bip32.cjs.
- Created test-keplr-path.cjs to validate Keplr-compatible derivation paths for Bitcoin.
- Introduced comprehensive tests for UTXO transactions in transaction.test.ts, covering fee estimation, transaction building, and error handling.
- Enhanced crypto tests to validate Bitcoin key derivation and address generation in keyring.test.ts.
- Updated chainRegistry tests to mock cosmos-registry module for better isolation.

* feat: implement IBC transfer functionality and modal in the dashboard

* Add fee validation for sweepAll transactions to prevent excessive fees (#53)

* Fix memory safety in deriveBitcoinKeyPairFromSeed key cleanup (#55)

* Secure pubKey cleanup in BIP32 child key derivation (#54)

* Update transaction.ts



* Update bitcoin.ts



* Update encrypted-storage.ts



* Update transaction.test.ts



* Update walletStore.ts



* Update ibc-connections.ts



* Update IBCTransferModal.tsx



* Update IBCTransferModal.tsx



* Update IBCTransferModal.tsx



* Update IBCTransferModal.tsx



* Update Dashboard.tsx



* Update chainRegistry.test.ts



* Update transaction.test.ts



* Simplify secureZero function in evm.ts to remove ineffective random overwrite (#56)

* Add BIP32 hardened derivation indicator documentation (#57)

* Fix memory leak in EVM BIP32 child key derivation (#58)

* Use actual UTXO count for Bitcoin max amount fee estimation (#59)

* Remove forceReDerive parameter from address derivation (#60)

* Refactor IBC connections to use pre-bundled data; remove runtime fetching and caching logic

- Updated `fetchIBCConnections` to utilize `getIBCChannelsForChainId` for fetching IBC connections.
- Removed caching mechanism and related functions for IBC connections.
- Re-exported `IBCChannel` type for backward compatibility.
- Cleaned up code and comments for clarity.
- Updated Cosmos registry file with new formatting and removed unnecessary comments.

* Optimize address caching with two-level structure to persist across network switches (#63)

* Initial plan

* Implement two-level cache for Bitcoin and EVM addresses

- Change cache structure from Map<cosmosAddress, address> to Map<cosmosAddress, Map<networkId, address>>
- Addresses now persist across network switches
- Only clear display state on network change, not the entire cache
- Check cache before re-deriving addresses to avoid redundant work
- Improves efficiency for users switching between networks



* Fix infinite loop in cache dependency arrays

- Remove cache state from useEffect dependencies to prevent infinite loops
- Use functional state updates to access previous cache state
- Separate cache checking and updating into distinct phases
- Maintains cache persistence while avoiding re-render cycles



* Refactor cache to use useRef instead of setState for reads

- Replace useState cache with useRef to avoid anti-pattern
- Use trigger state to force re-renders when cache updates
- Read directly from ref without needing setState callbacks
- Cleaner code that follows React best practices



---------




* Add runtime Buffer polyfill checks to prevent initialization order issues (#62)

* Initial plan

* Add runtime Buffer availability checks to prevent initialization order issues



* Refactor: Extract ensureBuffer to shared utility module



* Optimize Buffer checks: call ensureBuffer once at module level



* Add documentation explaining defensive Buffer check in ensureBuffer



---------




---------




* Add comprehensive tests for Solana and asset management functionality (#64)

* Add comprehensive tests for Solana and asset management functionality

- Introduced tests for known ERC20 and SPL tokens, validating structure, uniqueness, and common tokens.
- Implemented tests for Solana cryptography, including key derivation, address generation, and validation.
- Enhanced network registry tests to include SVM networks and their configurations.
- Developed extensive tests for Solana RPC client, covering balance retrieval, token balances, transaction handling, and error management.

* Update solana.test.ts



* Update knownAssets tests for BSC and Polygon token support (#65)

* Implement proper base58 decoding and 32-byte validation for Solana addresses (#66)

---------




---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants