-
Notifications
You must be signed in to change notification settings - Fork 1
Update knownAssets tests for BSC and Polygon token support #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com>
Deploying vidulum-app with
|
| Latest commit: |
92e249b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6487129.vidulum-app.pages.dev |
| Branch Preview URL: | https://copilot-sub-pr-64.vidulum-app.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the knownAssets test suite to reflect that getKnownErc20Tokens now returns non-empty token lists for BSC (56) and Polygon (137), instead of empty arrays.
Changes:
- Replaced the “non-Ethereum chains return empty array” assertions with chain-specific tests for BSC and Polygon.
- Added per-token structure validation (denom, symbol, name, decimals, contractAddress) and chainId checks for both chains.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tokens.forEach((token) => { | ||
| expect(token.denom).toBeDefined(); | ||
| expect(token.symbol).toBeDefined(); | ||
| expect(token.name).toBeDefined(); | ||
| expect(typeof token.decimals).toBe('number'); | ||
| expect(token.contractAddress).toBeDefined(); | ||
| expect(token.chainId).toBe(56); | ||
| }); |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new BSC test only checks that denom is defined, but other ERC20 token lists in this file also validate denom format (e.g. startsWith('erc20:')) and denom/contractAddress consistency via getErc20ContractAddress. Consider adding the same assertions here (and optionally the decimals range checks used in "Token Data Integrity") so BSC tokens get the same integrity coverage as Ethereum mainnet.
| tokens.forEach((token) => { | ||
| expect(token.denom).toBeDefined(); | ||
| expect(token.symbol).toBeDefined(); | ||
| expect(token.name).toBeDefined(); | ||
| expect(typeof token.decimals).toBe('number'); | ||
| expect(token.contractAddress).toBeDefined(); | ||
| expect(token.chainId).toBe(137); | ||
| }); |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as BSC: this Polygon test currently validates only presence/type of fields. To match the existing convention in this file, add denom prefix checks (erc20:) and consider asserting getErc20ContractAddress(token.denom) === token.contractAddress (and decimals bounds) so Polygon tokens are validated beyond being non-empty.
| it('should return tokens for BSC (chainId 56)', () => { | ||
| const tokens = getKnownErc20Tokens(56); | ||
| expect(tokens.length).toBeGreaterThan(0); | ||
| tokens.forEach((token) => { | ||
| expect(token.denom).toBeDefined(); | ||
| expect(token.symbol).toBeDefined(); | ||
| expect(token.name).toBeDefined(); | ||
| expect(typeof token.decimals).toBe('number'); | ||
| expect(token.contractAddress).toBeDefined(); | ||
| expect(token.chainId).toBe(56); | ||
| }); | ||
| }); |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two tests duplicate the same per-token structure assertions already used for ETH/Solana in this file. Consider extracting a small helper (e.g., expectValidErc20Token(token, chainId)) to keep the tests DRY and make future additions (more chainIds) less error-prone.
…#64) * Add comprehensive tests for Solana and asset management functionality - Introduced tests for known ERC20 and SPL tokens, validating structure, uniqueness, and common tokens. - Implemented tests for Solana cryptography, including key derivation, address generation, and validation. - Enhanced network registry tests to include SVM networks and their configurations. - Developed extensive tests for Solana RPC client, covering balance retrieval, token balances, transaction handling, and error management. * Update solana.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update knownAssets tests for BSC and Polygon token support (#65) * Implement proper base58 decoding and 32-byte validation for Solana addresses (#66) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app * Update src/popup/components/MoonPaySDKWidget.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Withdraw.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix MoonPay extension documentation to reflect new tab implementation (#48) * Initial plan * Update MoonPayWidget documentation to reflect new tab approach Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Fix MoonPay widget documentation to reflect new tab implementation (#49) * Initial plan * Update MoonPay integration documentation to reflect new tab behavior Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * Feature/changes and improvements (#52) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) (#50) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app * Update src/popup/components/MoonPaySDKWidget.tsx * Update Withdraw.tsx * Fix MoonPay extension documentation to reflect new tab implementation (#48) * Initial plan * Update MoonPayWidget documentation to reflect new tab approach --------- * Fix MoonPay widget documentation to reflect new tab implementation (#49) * Initial plan * Update MoonPay integration documentation to reflect new tab behavior --------- --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * feat: add BIP32 and BIP84 derivation tests for Bitcoin addresses - Implemented BIP32 derivation logic in test-bip32.cjs for generating child keys and addresses. - Added BIP84 path derivation for native SegWit addresses in test-bip32.cjs. - Created test-keplr-path.cjs to validate Keplr-compatible derivation paths for Bitcoin. - Introduced comprehensive tests for UTXO transactions in transaction.test.ts, covering fee estimation, transaction building, and error handling. - Enhanced crypto tests to validate Bitcoin key derivation and address generation in keyring.test.ts. - Updated chainRegistry tests to mock cosmos-registry module for better isolation. * feat: implement IBC transfer functionality and modal in the dashboard * Add fee validation for sweepAll transactions to prevent excessive fees (#53) * Fix memory safety in deriveBitcoinKeyPairFromSeed key cleanup (#55) * Secure pubKey cleanup in BIP32 child key derivation (#54) * Update transaction.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update bitcoin.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update encrypted-storage.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update transaction.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update walletStore.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ibc-connections.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update IBCTransferModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update IBCTransferModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update IBCTransferModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update IBCTransferModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Dashboard.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update chainRegistry.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update transaction.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Simplify secureZero function in evm.ts to remove ineffective random overwrite (#56) * Add BIP32 hardened derivation indicator documentation (#57) * Fix memory leak in EVM BIP32 child key derivation (#58) * Use actual UTXO count for Bitcoin max amount fee estimation (#59) * Remove forceReDerive parameter from address derivation (#60) * Refactor IBC connections to use pre-bundled data; remove runtime fetching and caching logic - Updated `fetchIBCConnections` to utilize `getIBCChannelsForChainId` for fetching IBC connections. - Removed caching mechanism and related functions for IBC connections. - Re-exported `IBCChannel` type for backward compatibility. - Cleaned up code and comments for clarity. - Updated Cosmos registry file with new formatting and removed unnecessary comments. * Optimize address caching with two-level structure to persist across network switches (#63) * Initial plan * Implement two-level cache for Bitcoin and EVM addresses - Change cache structure from Map<cosmosAddress, address> to Map<cosmosAddress, Map<networkId, address>> - Addresses now persist across network switches - Only clear display state on network change, not the entire cache - Check cache before re-deriving addresses to avoid redundant work - Improves efficiency for users switching between networks Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Fix infinite loop in cache dependency arrays - Remove cache state from useEffect dependencies to prevent infinite loops - Use functional state updates to access previous cache state - Separate cache checking and updating into distinct phases - Maintains cache persistence while avoiding re-render cycles Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Refactor cache to use useRef instead of setState for reads - Replace useState cache with useRef to avoid anti-pattern - Use trigger state to force re-renders when cache updates - Read directly from ref without needing setState callbacks - Cleaner code that follows React best practices Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Add runtime Buffer polyfill checks to prevent initialization order issues (#62) * Initial plan * Add runtime Buffer availability checks to prevent initialization order issues Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Refactor: Extract ensureBuffer to shared utility module Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Optimize Buffer checks: call ensureBuffer once at module level Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> * Add documentation explaining defensive Buffer check in ensureBuffer Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Corey-Code <37006206+Corey-Code@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * Add comprehensive tests for Solana and asset management functionality (#64) * Add comprehensive tests for Solana and asset management functionality - Introduced tests for known ERC20 and SPL tokens, validating structure, uniqueness, and common tokens. - Implemented tests for Solana cryptography, including key derivation, address generation, and validation. - Enhanced network registry tests to include SVM networks and their configurations. - Developed extensive tests for Solana RPC client, covering balance retrieval, token balances, transaction handling, and error management. * Update solana.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update knownAssets tests for BSC and Polygon token support (#65) * Implement proper base58 decoding and 32-byte validation for Solana addresses (#66) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app * Update src/popup/components/MoonPaySDKWidget.tsx * Update Withdraw.tsx * Fix MoonPay extension documentation to reflect new tab implementation (#48) * Initial plan * Update MoonPayWidget documentation to reflect new tab approach --------- * Fix MoonPay widget documentation to reflect new tab implementation (#49) * Initial plan * Update MoonPay integration documentation to reflect new tab behavior --------- --------- * Feature/changes and improvements (#52) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app (#47) (#50) * Feature - Integrate MoonPay SDK for buy/sell functionality in web app * Update src/popup/components/MoonPaySDKWidget.tsx * Update Withdraw.tsx * Fix MoonPay extension documentation to reflect new tab implementation (#48) * Initial plan * Update MoonPayWidget documentation to reflect new tab approach --------- * Fix MoonPay widget documentation to reflect new tab implementation (#49) * Initial plan * Update MoonPay integration documentation to reflect new tab behavior --------- --------- * feat: add BIP32 and BIP84 derivation tests for Bitcoin addresses - Implemented BIP32 derivation logic in test-bip32.cjs for generating child keys and addresses. - Added BIP84 path derivation for native SegWit addresses in test-bip32.cjs. - Created test-keplr-path.cjs to validate Keplr-compatible derivation paths for Bitcoin. - Introduced comprehensive tests for UTXO transactions in transaction.test.ts, covering fee estimation, transaction building, and error handling. - Enhanced crypto tests to validate Bitcoin key derivation and address generation in keyring.test.ts. - Updated chainRegistry tests to mock cosmos-registry module for better isolation. * feat: implement IBC transfer functionality and modal in the dashboard * Add fee validation for sweepAll transactions to prevent excessive fees (#53) * Fix memory safety in deriveBitcoinKeyPairFromSeed key cleanup (#55) * Secure pubKey cleanup in BIP32 child key derivation (#54) * Update transaction.ts * Update bitcoin.ts * Update encrypted-storage.ts * Update transaction.test.ts * Update walletStore.ts * Update ibc-connections.ts * Update IBCTransferModal.tsx * Update IBCTransferModal.tsx * Update IBCTransferModal.tsx * Update IBCTransferModal.tsx * Update Dashboard.tsx * Update chainRegistry.test.ts * Update transaction.test.ts * Simplify secureZero function in evm.ts to remove ineffective random overwrite (#56) * Add BIP32 hardened derivation indicator documentation (#57) * Fix memory leak in EVM BIP32 child key derivation (#58) * Use actual UTXO count for Bitcoin max amount fee estimation (#59) * Remove forceReDerive parameter from address derivation (#60) * Refactor IBC connections to use pre-bundled data; remove runtime fetching and caching logic - Updated `fetchIBCConnections` to utilize `getIBCChannelsForChainId` for fetching IBC connections. - Removed caching mechanism and related functions for IBC connections. - Re-exported `IBCChannel` type for backward compatibility. - Cleaned up code and comments for clarity. - Updated Cosmos registry file with new formatting and removed unnecessary comments. * Optimize address caching with two-level structure to persist across network switches (#63) * Initial plan * Implement two-level cache for Bitcoin and EVM addresses - Change cache structure from Map<cosmosAddress, address> to Map<cosmosAddress, Map<networkId, address>> - Addresses now persist across network switches - Only clear display state on network change, not the entire cache - Check cache before re-deriving addresses to avoid redundant work - Improves efficiency for users switching between networks * Fix infinite loop in cache dependency arrays - Remove cache state from useEffect dependencies to prevent infinite loops - Use functional state updates to access previous cache state - Separate cache checking and updating into distinct phases - Maintains cache persistence while avoiding re-render cycles * Refactor cache to use useRef instead of setState for reads - Replace useState cache with useRef to avoid anti-pattern - Use trigger state to force re-renders when cache updates - Read directly from ref without needing setState callbacks - Cleaner code that follows React best practices --------- * Add runtime Buffer polyfill checks to prevent initialization order issues (#62) * Initial plan * Add runtime Buffer availability checks to prevent initialization order issues * Refactor: Extract ensureBuffer to shared utility module * Optimize Buffer checks: call ensureBuffer once at module level * Add documentation explaining defensive Buffer check in ensureBuffer --------- --------- * Add comprehensive tests for Solana and asset management functionality (#64) * Add comprehensive tests for Solana and asset management functionality - Introduced tests for known ERC20 and SPL tokens, validating structure, uniqueness, and common tokens. - Implemented tests for Solana cryptography, including key derivation, address generation, and validation. - Enhanced network registry tests to include SVM networks and their configurations. - Developed extensive tests for Solana RPC client, covering balance retrieval, token balances, transaction handling, and error management. * Update solana.test.ts * Update knownAssets tests for BSC and Polygon token support (#65) * Implement proper base58 decoding and 32-byte validation for Solana addresses (#66) --------- --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Tests for
getKnownErc20Tokenswere asserting empty arrays for BSC (chainId 56) and Polygon (chainId 137), but the implementation now returnsBNB_ERC20_TOKENSandPOLYGON_ERC20_TOKENSfor these chains.Changes
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.