Skip to content

feat(tui): lock v2 runtime chrome - #21

Merged
echobt merged 3 commits into
mainfrom
cursor/tui-lock-v2-runtime-5af0
Sep 5, 2026
Merged

feat(tui): lock v2 runtime chrome#21
echobt merged 3 commits into
mainfrom
cursor/tui-lock-v2-runtime-5af0

Conversation

@echobt

@echobt echobt commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Runtime implementation of the Cortex CLI TUI lock v2. Separate from design pack #20. SPEC + txt grids are vendored so scripts/render-tui-lock-v2.sh can recapture the live session; designer PNGs stay on #20.

Do not merge until Designer cli signs off on runtime captures. Invite Designer cli to QA again (Oding will ping).

CAPTURES_FIXED_PASS

Live MockTerminal recapture of the full SPEC §7 set. Each filename is one unique state — no two PNGs share a sha256.

  • PR: feat(tui): lock v2 runtime chrome #21
  • Regenerate: ./scripts/render-tui-lock-v2.sh (fails if hashes collide or counts are short)
  • 120×40: 77 files, 77 unique hashes
  • 40×12: 31 files, 31 unique hashes

Previously aliased frames are now distinct:

  • session-user-barssession-thoughtsession-assistant
  • settings-appearancesettings-row-hover (BAR_HOVER on Show timestamps)
  • welcome-cortexcomposer-emptyfooter-shortcuts

Test plan

  • cargo fmt --all -- --check
  • ./scripts/clippy.sh
  • cargo test -p cortex-tui --lib lock_v2 (unique ANSI frames at both sizes)
  • ./scripts/render-tui-lock-v2.sh — 77 + 31 unique sha256
  • CI cargo test --workspace / cargo audit on this commit

Attestation (required)

I attest that:

  • Security reviewed — auth, exec/sandbox, path traversal, network egress, and secret handling in this diff were reviewed. No secrets, tokens, or keyring dumps are in the change.
  • Product-facing errors — user-visible failures use Cortex product copy. API-down paths say The coding service is temporarily unavailable. No raw provider, SDK, or transport names.
  • TUI verified — every TUI surface touched in this PR was exercised (build + headless snapshot / ratatui-style test). Runtime PNGs recaptured; no interactive TTY run in this environment.
  • Tests added — unit tests cover the new logic; TUI changes include a snapshot or buffer assertion. No mocks that report success.
  • No secrets — no API keys, WorkOS secrets, R2/AWS credentials, or .env files are included.

Risk

TUI-only. Alternate screen stays default always. agent is a second bin target on the same main.rs. Ctrl+x is the shortcuts overlay (no longer “clear queue”).

Open in Web Open in Cursor 

cursoragent and others added 2 commits September 5, 2026 23:04
Ship the inky Cortex TUI: dual-hairline composer, shortcut footer,
slash palette hover, High→Low effort radios, settings modal, Ctrl+x
overlay, agent bin, and 12h timestamps. Vendor SPEC/txt grids for
runtime captures.

Co-authored-by: Mathis <echobt@users.noreply.github.com>
Headless MockTerminal captures at 40×12 and 120×40, plus clippy and
lock_proof updates so v2 chrome (rounded composer, shortcut footer)
passes the session tests.

Co-authored-by: Mathis <echobt@users.noreply.github.com>
@echobt
echobt marked this pull request as ready for review September 5, 2026 23:24
@echobt
echobt marked this pull request as draft September 5, 2026 23:26
Expand lock v2 MockTerminal scenes to the full SPEC §7 set (77 at
120×40, 31 at 40×12) so each filename is a unique live state. Reject
identical PNG hashes in the recapture script.

Co-authored-by: Mathis <echobt@users.noreply.github.com>
@echobt
echobt marked this pull request as ready for review September 5, 2026 23:43
@echobt
echobt merged commit 6cef6f8 into main Sep 5, 2026
10 checks passed
@echobt
echobt deleted the cursor/tui-lock-v2-runtime-5af0 branch September 5, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants