fix: Prevent reading special device files and limit file size in cortex run#9
Merged
fix: Prevent reading special device files and limit file size in cortex run#9
Conversation
echobt
force-pushed
the
fix/issue-1564
branch
from
38f091f to
35394e9
Compare
echobt
force-pushed
the
fix/issue-1564
branch
from
35394e9 to
1c2d5fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1564 where
cortex run --file /dev/zerowould hang indefinitely due to reading an infinite stream.Changes
run_cmd.rsto check if the path is a regular file or directory.Testing
/dev/zero(now fails gracefully).