Skip to content

fix: Prevent reading special device files and limit file size in cortex run #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echobt merged 1 commit into from
Jan 26, 2026
Merged

fix: Prevent reading special device files and limit file size in cortex run #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cortex-cli/src/run_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,19 @@ impl RunCli {
format!("Failed to read file metadata: {}", resolved_path.display())
})?;

if !metadata.is_file() && !metadata.is_dir() {
bail!(
"File is not a regular file or directory: {}",
file_path.display()
);
}

// Max file size check (e.g. 10MB) to prevent OOM
const MAX_FILE_SIZE: u64 = 10 * 1024 * 1024;
if metadata.len() > MAX_FILE_SIZE {
bail!("File too large (max 10MB): {}", file_path.display());
}

let filename = resolved_path
.file_name()
.map(|n| n.to_string_lossy().to_string())
Expand Down
Loading