fix(change): heal reopen closing-approval recovery (#445/#481) - #485
Merged
Conversation
Bind reopen to the historical verification that authenticates the closing approval when verification.json has drifted, persist a finalization terminal approval for workflow v2, allow definition re-approval while accepted when stale, and refuse legacy finalize with accept/archive guidance.
0xLeif
requested review from
0xGaspar,
Kyntrin and
tofu-ux
and removed request for
a team
August 1, 2026 02:17
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
Lifecycle: CHG-0072 verified, reviewed, and archived on this tip. |
This was referenced Aug 1, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... validation failed..."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ❌ failure |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ❌ cancelled |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 2 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (124652/124652) |
Errors
- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Action Items
- Review and fix -- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
- Review and fix -- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
0xLeif
force-pushed
the
leif/fix-reopen-closing-approval
branch
from
August 1, 2026 03:21
10f3087 to
2efdc0c
Compare
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... your imports are all over the place."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ❌ failure |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ❌ cancelled |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 2 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (124652/124652) |
Errors
- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Action Items
- Review and fix -- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
- Review and fix -- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... validation failed..."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ❌ cancelled |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 1 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (124650/124650) |
Errors
- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Action Items
- Review and fix -- meaningful changed paths are not covered by an active change: tests/integration/change.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... validation failed..."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ❌ cancelled |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 1 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (124650/124650) |
Errors
- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
Action Items
- Review and fix -- CHG-0072-heal-reopen-closing-approval-recovery-for-stale-accepted-evidence: verification evidence is stale for the current commit or contract
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
change reopento the historical verification attempt that authenticates the closing approval whenverification.jsonhas driftedfinalizationledger approval on workflow-v2 same-PR finalize so reopen can supersede itchange approvewhile accepted when definition digest is stale (reopen recovery)finalizewith clearaccept+archiveguidanceCloses #445 (reopen recovery dead-end for closing/definition). Addresses #481 reopen/archive deadlock class.
Test Plan
cargo clippy -- -D warningscargo test change::tests::(291)