-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/159 psf output from trained model #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeipollack
wants to merge
130
commits into
develop
Choose a base branch
from
feature/159-psf-output-from-trained-model
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f15c0f2 to
89da2e0
Compare
c199e05 to
9f64df3
Compare
…ean up submodule docs, update conf.py, and update pyproject.toml version
- Removed old auto-generated wf_psf.rst from _autosummary - Updated toc.rst (fixed tab issues, reference api.rst) - Added api.rst with :recursive: directive and wf_psf.run entrypoint - Refined __init__.py docstrings for all subpackages for clarity and consistency - Updated module-level docstrings (purpose, authors, TensorFlow notes, etc.)
- Shorten sections to make developer-friendly - Added new structure for each section: Purppose, Key Fields, Notes, General Notes, etc, where applicable - Partial completion - new PR is required to verify optional versus required settings
- Added cross-references between config sections - Clarified required fields for ground_truth_model.model_params - Updated General Notes and reorganized section numbering - Improved examples and directory structures - Fixed build warnings due to missing anchors and code block lexing
…odels and tf_modules, add/rm modules, update import statements and tests
- Updated classes and methods with complete doc strings - Added two cache clearing methods to PSFInference and PSFInferenceEngine classes
e995e7c to
6b2a1fe
Compare
Rebase dropped commits that removed weights_path from the metrics interface. Cleaning up remaining references in docstrings and tests.
Use f-strings instead of %-formatting to properly display percent symbols in metric output.
Contributor
Author
|
it would be very ideal to squash and merge this commit in order to simplify rebasing the other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds inference capabilities to the WaveDiff / WF-PSF framework, allowing the user to generate broadband (polychromatic) PSFs from a trained model, given a list of positions and SEDs.
It had a refactor PR merged into it in order to carry on with the development which is why it contains >100 commits (unfortunately and not a practice that will be repeated).
Closes #159 (Validation runs described there)
Key Changes
psf_inference.pyand associatedtest_inferencepackages for PSF inference workflowsTFPhysicalPolychromaticand related modules to separate training vs. inference behaviourPSFInferenceEngineclass to centralise training, simulation, metrics, and inference logicpsf_model_loader.pydata_handlerinference_config.yaml)run_typeattribute: Added to data_handler supporting training, simulation, metrics, and inference modesZernikeInputsdata class: Now intelligently assembles Zernike contribution lists based on run_type and available data (including priors and source positions for CCD misalignment corrections)tf_utils.pymodule in thepsf_modelssub-packageDataHandlerclass that prevented training dataset images from being converted to TensorFlow data type as expectedget_obs_positionsas it was no longer neededmetrics.py(values were not being displayed)Testing
developcode