Skip to content

Enable http logging interceptor in retrofit client only if isDebug is true#12

Merged
goke-epapa merged 3 commits intomasterfrom
fixes/http-logging-fixes
Feb 5, 2018
Merged

Enable http logging interceptor in retrofit client only if isDebug is true#12
goke-epapa merged 3 commits intomasterfrom
fixes/http-logging-fixes

Conversation

@goke-epapa
Copy link
Copy Markdown
Contributor

This PR fixes - #11.

@rasheedsulayman
Copy link
Copy Markdown
Member

CI failing

@rasheedsulayman
Copy link
Copy Markdown
Member

rasheedsulayman commented Jan 31, 2018

This PR fixes it. #13

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 4, 2018

Codecov Report

Merging #12 into master will decrease coverage by 0.46%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   69.95%   69.49%   -0.47%     
==========================================
  Files           9        9              
  Lines         233      236       +3     
  Branches       11       12       +1     
==========================================
+ Hits          163      164       +1     
- Misses         62       63       +1     
- Partials        8        9       +1

@goke-epapa goke-epapa merged commit 8f5f0a4 into master Feb 5, 2018
@goke-epapa goke-epapa deleted the fixes/http-logging-fixes branch February 5, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants