chore : modify tests for updated methods#13
Merged
JubrilEdu merged 1 commit intofixes/http-logging-fixesfrom Feb 4, 2018
Merged
chore : modify tests for updated methods#13JubrilEdu merged 1 commit intofixes/http-logging-fixesfrom
JubrilEdu merged 1 commit intofixes/http-logging-fixesfrom
Conversation
rasheedsulayman
requested review from
JubrilEdu,
beccadaniel,
codedentwickler and
goke-epapa
rasheedsulayman
changed the title
rasheedsulayman
changed the title
Contributor
|
Thanks @r4sh33d |
goke-epapa
approved these changes
Jan 31, 2018
Contributor
goke-epapa
left a comment
goke-epapa
left a comment
There was a problem hiding this comment.
Looks good, I totally forgot the tests.
Thanks for setting up a good CI process.
JubrilEdu
approved these changes
Feb 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes CI build failure issue, by updating the tests for the changed methods