[SER-2423] Publish toogle converted to button#6223
Merged
coskunaydinoglu merged 10 commits intojourney+content-mainfrom May 29, 2025
Merged
[SER-2423] Publish toogle converted to button#6223coskunaydinoglu merged 10 commits intojourney+content-mainfrom
coskunaydinoglu merged 10 commits intojourney+content-mainfrom
Conversation
coskunaydinoglu
requested review from
ArtursKadikis,
John-Weak,
ar2rsawseen,
Copilot,
gabrieloliveirapinto,
kanwarujjaval and
pnrgenc
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the publish toggle behavior by replacing the el-switch component with an el-button in the UI and updating the related component logic.
- Removed the el-switch and added an el-button to handle publish/unpublish actions in the content header template.
- Added an onPublishButtonClick method in the content component to toggle the publish state.
- Updated the CHANGELOG to reflect these changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/express/public/javascripts/countly/vue/templates/content/content-header.html | Replaced the toggle switch with a button for publishing actions. |
| frontend/express/public/javascripts/countly/vue/components/content.js | Introduced onPublishButtonClick method and reorganized computed properties. |
| CHANGELOG.md | Updated release notes to mention the conversion of the toggle to a button. |
…tent.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…m/Countly/countly-server into SER-2423-journey-publish-toggled-into-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.