fix: db validation in mutation manager job #7109
Merged
+56
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the mutation manager job where all MongoDB operations were being performed on the drill database (common.drillDb) regardless of the specified target database in the task. The fix introduces proper database selection and validation logic to ensure mutations are applied to the correct database.
Key Changes:
- Added a database lookup mechanism (
MONGO_DATABASESandgetMongoDbInstance) to dynamically select the correct MongoDB instance based ontask.db - Implemented validation to ensure at least one backend (MongoDB or ClickHouse) is available before processing mutation tasks
- Updated
deleteMongoandupdateMongomethods to accept and use the correct database instance instead of hardcodingcommon.drillDb
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kanwarujjaval
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.