Skip to content

Survey: Support for Time Bonus EXP end time#5048

Merged
ekowidianto merged 7 commits intomasterfrom
phillmont/add-survey-bonus-end-date
Sep 2, 2022
Merged

Survey: Support for Time Bonus EXP end time#5048
ekowidianto merged 7 commits intomasterfrom
phillmont/add-survey-bonus-end-date

Conversation

@pchunky
Copy link
Copy Markdown
Contributor

@pchunky pchunky commented Sep 2, 2022

Closes #4989.

Time Bonus EXP for surveys now follows the following behaviour:

  • Bonus end time must be between survey opening and closing times.
  • Time Bonus EXP is awarded if a survey is submitted between opening and bonus end times.
  • Only Base EXP is awarded if a survey is submitted between bonus end and closing times.
  • 'Allow responses after survey closes' option no longer modifies the Time Bonus EXP behaviour.

@pchunky pchunky self-assigned this Sep 2, 2022
@pchunky pchunky force-pushed the phillmont/add-survey-bonus-end-date branch from 02a87d6 to 487022e Compare September 2, 2022 09:41
@pchunky
Copy link
Copy Markdown
Contributor Author

pchunky commented Sep 2, 2022

I will push the UI changes in a separate PR. I need some of the changes I made in #5034 and #5049. This PR is ready for merging.

@pchunky pchunky requested a review from ekowidianto September 2, 2022 10:25
Copy link
Copy Markdown
Member

@ekowidianto ekowidianto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @purfectliterature thanks!

@ekowidianto ekowidianto enabled auto-merge (rebase) September 2, 2022 16:23
@ekowidianto ekowidianto disabled auto-merge September 2, 2022 16:38
@ekowidianto ekowidianto merged commit ac6b06c into master Sep 2, 2022
@ekowidianto ekowidianto deleted the phillmont/add-survey-bonus-end-date branch September 2, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bonus end at date to survey form

2 participants