Allow Instance Admin and Instance Instructor to Duplicate Courses across Instances#7095
Merged
Merged
Conversation
- allow instance instructor and instance admin to duplicate across instances - the user duplicating should not be instance normal for both instances
bivanalhar
force-pushed
the
bivan/instance_user_duplicate_course
branch
from
75a4a87 to
0b1f1e2
Compare
- test duplication feasibility across instances - test instances and courses list for controller new in duplication
bivanalhar
force-pushed
the
bivan/instance_user_duplicate_course
branch
from
a009ad0 to
820a8f9
Compare
ekowidianto
requested changes
Feb 14, 2024
Member
ekowidianto
left a comment
ekowidianto
left a comment
There was a problem hiding this comment.
Thanks! @bivanalhar some comments
- define destination_tenant more clearly - split admin user from others in destination instance logic - take out business logic for instance dropdown in backend
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Previously, only administrator of Coursemology can do the duplication of course between instances, while other people having privileges in duplicating the course can only do that within the instance they're in.
Objective
In this PR, we decided to allow the instance instructor as well as instance admin to duplicate courses within their instance. The rulings that we apply are as follows:
Result
As shown below, if user is at least instance instructor in the instance Default and Raffles Institution, those 2 options will be available in the Duplication Page, in the Destination Instance section
On the other hand, if a user is only the instance admin/instructor in one instance (and either instance normal or none in other instances), then the option for Destination Instance will be fixed and user will not be able to modify it
