Skip to content

Conversation

@Japleen-Kaur2409
Copy link
Contributor

Proposed Changes

This pull request fixes a bug in the course information modal where the course title did not display the H1/S1/Y1 suffix (session code).
Previously, the modal header showed only the course code and name (e.g., CSC236 Introduction to the Theory of Computation), which was inconsistent with how courses are labelled elsewhere in the interface.
...

##Before Screenshot 2025-10-28 at 10 00 32 PM

##After
Screenshot 2025-10-28 at 9 59 54 PM
)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [] I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@Japleen-Kaur2409
Copy link
Contributor Author

Screenshot 2025-10-28 at 10 18 43 PM This test is failing in CourseModalButtons.test.js, Please guide me.

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Japleen-Kaur2409 nice work!

@david-yz-liu david-yz-liu merged commit 014ae00 into Courseography:master Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants