Merge pull request #2 from CraigBuckmaster/master#3
Merged
CraigBuckmaster merged 1 commit intoMar 13, 2026
Merged
Conversation
Merge pull request #1 from CraigBuckmaster/codex/review-recent-master…
CraigBuckmaster
added a commit
that referenced
this pull request
Mar 13, 2026
Merge pull request #3 from CraigBuckmaster/codex/review-recent-master…
CraigBuckmaster
pushed a commit
that referenced
this pull request
Mar 25, 2026
…reenHeader component + 8 screen migrations P1 fixes from UI_UX_AUDIT.md: 1. ErrorBoundary (#2): wraps RootNavigator in App.tsx. Prod crashes now show a styled recovery screen with Retry button instead of white screen. 2. NotesOverlay (#1): rendered in ChapterScreen with notesOverlayOpen state from readerStore. Notes toggle actually opens the overlay now. Added bookName prop for proper display name (was showing raw bookId). 3. Back navigation (#3): new ScreenHeader component replaces 8 separate header implementations. ArrowLeft back button, title, optional subtitle, optional titleColor override, accessibility role/label built in. Screens gaining back buttons: BookmarkListScreen, ReadingHistoryScreen, PlanListScreen, PlanDetailScreen, ScholarBioScreen, WordStudyDetailScreen. Screens migrated to shared component: SettingsScreen, ChapterListScreen. Removed ~50 lines of duplicated header styles. Files: 12 changed, +145/-93
CraigBuckmaster
added a commit
that referenced
this pull request
Mar 29, 2026
…-push-for-genesis-chapters Merge pull request #2 from CraigBuckmaster/master
CraigBuckmaster
added a commit
that referenced
this pull request
Mar 29, 2026
Merge pull request #3 from CraigBuckmaster/codex/review-recent-master…
CraigBuckmaster
pushed a commit
that referenced
this pull request
Mar 29, 2026
…reenHeader component + 8 screen migrations P1 fixes from UI_UX_AUDIT.md: 1. ErrorBoundary (#2): wraps RootNavigator in App.tsx. Prod crashes now show a styled recovery screen with Retry button instead of white screen. 2. NotesOverlay (#1): rendered in ChapterScreen with notesOverlayOpen state from readerStore. Notes toggle actually opens the overlay now. Added bookName prop for proper display name (was showing raw bookId). 3. Back navigation (#3): new ScreenHeader component replaces 8 separate header implementations. ArrowLeft back button, title, optional subtitle, optional titleColor override, accessibility role/label built in. Screens gaining back buttons: BookmarkListScreen, ReadingHistoryScreen, PlanListScreen, PlanDetailScreen, ScholarBioScreen, WordStudyDetailScreen. Screens migrated to shared component: SettingsScreen, ChapterListScreen. Removed ~50 lines of duplicated header styles. Files: 12 changed, +145/-93
CraigBuckmaster
pushed a commit
that referenced
this pull request
Apr 3, 2026
CodeQL alert #3: The regex /<[^>]*>/g only strips tags in one pass, so crafted input like <scr<script>ipt> could survive. Loop until no tags remain to fully sanitize. https://claude.ai/code/session_012iuiZXQvD4jD9oTbQoCZ6z
This was referenced Apr 15, 2026
CraigBuckmaster
pushed a commit
that referenced
this pull request
Apr 23, 2026
Blockers: #1 userDatabase.ts v6 migration — add prominent SQL-quoting warning comment explaining why JSON.stringify + single-quoted SQL literal is safe, so future edits don't break it #2 review.ts / userMutations.ts — spaced repetition was pre-creating all 4 interval rows (1/3/7/30d) up front, causing users to see 3 copies of each prompt between day 7 and day 30. Now schedules ONE row at interval 1; completeGuidedReviewItem inserts the next-interval row in the same transaction via new nextIntervalAfter() helper #3 build_sqlite_loaders.py — proof_text_guards loader was silently falling back to guard's own book/chapter on missing suggested_chapter. Now raises ValueError with the offending guard ref. (Note: self-reference itself is valid — it's the UX for 'read in full chapter context' — so equal values are allowed, only missing/malformed values fail) #4 guidedStudy.test.ts — fixture used 'at_a_glance: [...] as any' which disabled TS checking. Replaced with correctly-typed ParsedBookIntro containing a full BookIntroAtAGlance object, so the bookIntro code path in buildConceptChips is now actually exercised #5 userDatabase.ts — new migration v20 adds partial unique index on guided_study_sessions(chapter_id) WHERE status='active' to prevent session leaks from crashes between insert and status flip. Migration dedupes any existing duplicates to the most recently updated row first Nits: #7 types/user.ts — export GUIDED_STUDY_STEPS const; derive GuidedStudyStep type from it; add GUIDED_STUDY_STEP_LABELS map in guidedStudy/types.ts; StudySessionStepper consumes both. Migration SQL CHECK gets a comment pointing at the const as single source of truth #8 plan.ts — CONCEPT_WORDS and genrePrompt refactored; concepts gets TODO(#1584); genrePrompt switched from label.includes(...) substring match to exact Record<label,prompt> lookup (with fallback for unknown genres). Filed #1584 to migrate concepts to content/meta/concepts.json #9 ChapterScreen.tsx + navigation/types.ts — added TODO(#1585) comments around the nav escape hatch. Filed #1585 to track typed CrossTabNavProp #10 StudySessionScreen.tsx — Amicus seed query fields now truncated to 200 chars with ellipsis sentinel so long syntheses don't blow past the peek sheet or Amicus's seed-query limit #12 .gitattributes — added '* text=auto eol=lf' + binary asset list. Normalized CRLF → LF on translations.json and db-manifest.json Deferred (filed/noted separately): #6 EraTimeline RAF cleanup — legit scope creep, but splitting now is more ceremony than benefit for a solo-dev PR. Kept bundled #11 GoldStripeListItem primitive — real refactor opportunity touching 5 components; out of scope for a review-response commit Tracking issues: #1584 (concepts from meta), #1585 (typed CrossTabNavProp)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #1 from CraigBuckmaster/codex/review-recent-master…