refactor: code review fixes — bugs, perf, readability, structure#9
Merged
Merged
Conversation
Bug fixes: - Remove duplicate scholar color keys (moo, schreiner) in colors.ts - Fix duplicate UIBackgroundModes entry in app.json - Add missing ScreenRouteProp import in TimelineScreen - Tighten SectionWithPanels.panels type from Record<string, unknown> to Record<string, object> Performance: - Wrap VerseBlock in React.memo (rendered per-verse in chapters) - Extract memoized BookRow component in BookListScreen - Wrap SearchScreen sections array in useMemo Architecture & readability: - Extract useSwipeNavigation hook from ChapterScreen (340→305 lines) - Convert TimelineScreen 4× useState filter booleans to useReducer - Add deep-link guard ref in MapScreen to prevent re-firing - Move PanelContainer inline styles to StyleSheet.create - Document settings store fire-and-forget persistence pattern Tooling: - Add "test" script to package.json https://claude.ai/code/session_01JJgJzuEgGBXYr1LwcU9AEP
This was referenced Apr 15, 2026
CraigBuckmaster
pushed a commit
that referenced
this pull request
Apr 23, 2026
Blockers: #1 userDatabase.ts v6 migration — add prominent SQL-quoting warning comment explaining why JSON.stringify + single-quoted SQL literal is safe, so future edits don't break it #2 review.ts / userMutations.ts — spaced repetition was pre-creating all 4 interval rows (1/3/7/30d) up front, causing users to see 3 copies of each prompt between day 7 and day 30. Now schedules ONE row at interval 1; completeGuidedReviewItem inserts the next-interval row in the same transaction via new nextIntervalAfter() helper #3 build_sqlite_loaders.py — proof_text_guards loader was silently falling back to guard's own book/chapter on missing suggested_chapter. Now raises ValueError with the offending guard ref. (Note: self-reference itself is valid — it's the UX for 'read in full chapter context' — so equal values are allowed, only missing/malformed values fail) #4 guidedStudy.test.ts — fixture used 'at_a_glance: [...] as any' which disabled TS checking. Replaced with correctly-typed ParsedBookIntro containing a full BookIntroAtAGlance object, so the bookIntro code path in buildConceptChips is now actually exercised #5 userDatabase.ts — new migration v20 adds partial unique index on guided_study_sessions(chapter_id) WHERE status='active' to prevent session leaks from crashes between insert and status flip. Migration dedupes any existing duplicates to the most recently updated row first Nits: #7 types/user.ts — export GUIDED_STUDY_STEPS const; derive GuidedStudyStep type from it; add GUIDED_STUDY_STEP_LABELS map in guidedStudy/types.ts; StudySessionStepper consumes both. Migration SQL CHECK gets a comment pointing at the const as single source of truth #8 plan.ts — CONCEPT_WORDS and genrePrompt refactored; concepts gets TODO(#1584); genrePrompt switched from label.includes(...) substring match to exact Record<label,prompt> lookup (with fallback for unknown genres). Filed #1584 to migrate concepts to content/meta/concepts.json #9 ChapterScreen.tsx + navigation/types.ts — added TODO(#1585) comments around the nav escape hatch. Filed #1585 to track typed CrossTabNavProp #10 StudySessionScreen.tsx — Amicus seed query fields now truncated to 200 chars with ellipsis sentinel so long syntheses don't blow past the peek sheet or Amicus's seed-query limit #12 .gitattributes — added '* text=auto eol=lf' + binary asset list. Normalized CRLF → LF on translations.json and db-manifest.json Deferred (filed/noted separately): #6 EraTimeline RAF cleanup — legit scope creep, but splitting now is more ceremony than benefit for a solo-dev PR. Kept bundled #11 GoldStripeListItem primitive — real refactor opportunity touching 5 components; out of scope for a review-response commit Tracking issues: #1584 (concepts from meta), #1585 (typed CrossTabNavProp)
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes:
Performance:
Architecture & readability:
Tooling:
https://claude.ai/code/session_01JJgJzuEgGBXYr1LwcU9AEP