Improvement/merge suggestions worker #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
improvement/members-enrichment-worker
to
main
December 22, 2023 14:43
joanreyero
reviewed
Jan 2, 2024
Contributor
joanreyero
left a comment
joanreyero
left a comment
There was a problem hiding this comment.
Good job! Just a couple of nitpicks. Otherwise, it looks good to me!
...apps/merge_suggestions_worker/src/activities/member-merge-suggestions/getMergeSuggestions.ts
Show resolved
Hide resolved
services/apps/merge_suggestions_worker/src/repo/memberMergeSuggestions.repo.ts
Outdated
Show resolved
Hide resolved
epipav
added a commit
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Loïc Saint-Roch <loic@nunchi.studio>
epipav
pushed a commit
that referenced
this pull request
Jan 4, 2024
Improvement/merge suggestions worker (#1971) Co-authored-by: Loïc Saint-Roch <loic@nunchi.studio> typo fixed in workflow names filtering out null email values when getting merge suggestions deduplication using window function instead for stable results in merge suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖[deprecated] Generated by Copilot at 0005c07
No summary available (Limit exceeded: required to process 133064 tokens, but only 50000 are allowed per call)
🤖[deprecated] Generated by Copilot at 58c335a
Why
How
🤖[deprecated] Generated by Copilot at 0005c07
No walkthrough available (Limit exceeded: required to process 133064 tokens, but only 50000 are allowed per call)
Checklist ✅
Feature,Improvement, orBug.