Some improvements#53
Conversation
Galster-dev
left a comment
Galster-dev
left a comment
There was a problem hiding this comment.
Thanks for you contribution. Due to stability and compatibility level we're aiming at, we cannot accept this PR without noted changes. I'm absolutely down to implement those changes myself, but if you want to do it, I'm not complaining.
|
|
||
| var tmp = playerButton.GetComponentInChildren<TextMeshPro>(); | ||
| var newValue = Mathf.Max(byte.Parse(tmp.text) - 10, byte.Parse(playerButton.name)); | ||
| var newValue = Mathf.Max(byte.Parse(tmp.text) - 10, byte.Parse(playerButton.name) - 2); |
There was a problem hiding this comment.
I'd stick to 4 tbh, but 3 is fine I guess
There was a problem hiding this comment.
honestly i thought of it as funny seeing a 3 player lobby, it's merely a joke-ish change which i'm willing to change to 4 if needed
|
oops accidentally requested review my bad will make those changes |
|
im thinking of moving PageText.text = $"({PageIndex + 1}/{MaxPageIndex + 1})"; into the OnPageChanged() method instead of Update() |
|
worked on it a wee bit more, and went ahead with my earlier idea |
|
so is this pr good enough to be merged? or is there something else that's to be done |
|
@Galster-dev made your requested changes |
| { | ||
| __instance.CrewArea.SetCrewSize(opts.MaxPlayers, opts.NumImpostors); | ||
| } | ||
| __instance.CrewArea?.SetCrewSize(opts.MaxPlayers, opts.NumImpostors); |
There was a problem hiding this comment.
? operator bypasses Unity lifetime checks
2 participants
This pr contains
Haven't been able to test it fully since 15+ player lobbies are rare, but through some solo testing using bots they work for the most part