ContactRow Component#23
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cru/mpdx-react/AxNY8KihRrHTKgKuxpEL9zZX6vHC |
TheNoodleMoose
left a comment
TheNoodleMoose
left a comment
There was a problem hiding this comment.
Looks good, should the design updates for the contact row be in a separate pr?
There was a problem hiding this comment.
What was this added for?
There was a problem hiding this comment.
It seems that a lot of packages don't import dependencies correctly. In this case storybook-addon-designs. Yarn V1 and npm don't seem to care. Yarn V2 throws errors. I've just been adding them when it complains. I wish I didn't have to. Maybe there's another way.
There was a problem hiding this comment.
https://yarnpkg.com/features/pnp#pnp-loose-mode Seems it's due to strict mode. The package's source imports something that is not in it's dependencies but is in a child dependency's dependencies. We enable lose mode if this gets too annoying...
OzzieOrca
force-pushed
the
contactrow-component
branch
from
76c5752 to
fdd77f7
Compare
- #23 config-driven import graph: resolveImport/buildGraph/indexStore take aliases/ extensions/roots from config.index (defaults preserved); schema + tests - #4 single arg parser (engine/args.cjs) used by plan/impact/indexStore/learningsStore (no more 4 divergent parsers); review:* scripts repointed to the cli.cjs dispatcher; cli index --force - #5 command gates index/learning via 'review config get', not raw grep of config.yml - #1 auto-fix apply_all.sh now DRY-RUNS untrusted model-generated scripts; applies only with --yes - 68 tests pass
2 participants
Create initial ContactRow component for displaying information about a single contact on the Contacts list page.
I haven't added any designs here yet. You could pick up from where I left off here if you are interested.