Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates translation resources: increases translation coverage in TRANSLATIONS.md and adds/updates string and plural entries for Czech ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/res/values-cs/strings.xml`:
- Line 47: Remove the embedded "\n" escapes from user-visible Czech strings so
they don’t render stray blank lines: edit the string resource named
"biometric_backup_advice" to drop the trailing "\n" and similarly remove any
leading/trailing "\n" escapes from each plural item under
"notes_too_big_truncating" in the Czech locale (the plural entries around the
250–275 region) so the messages render without extra blank lines.
- Line 352: The Czech strings.xml removed the older text-size labels required by
NotallyXPreferences.kt; restore localized entries for the two resource names
used there (text_size_note_editor and text_size_overview) so those keys remain
available until the code switches to the new key (text_size). Update the values
in values-cs/strings.xml to include <string
name="text_size_note_editor">…</string> and <string
name="text_size_overview">…</string> (localized Czech text) so
R.string.text_size_note_editor and R.string.text_size_overview referenced by
NotallyXPreferences.kt continue to resolve.
In `@app/src/main/res/values-zh-rCN/strings.xml`:
- Line 341: The locale file is missing the two resource keys referenced by
NotallyXPreferences.kt (R.string.text_size_note_editor and
R.string.text_size_overview); add string entries for "text_size_note_editor" and
"text_size_overview" (with appropriate Simplified Chinese translations, e.g.,
matching "文本大小") to the strings.xml alongside the existing "text_size" key so
the preference rows resolve to the localized strings instead of falling back to
the default locale.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 20a6ec8c-1dc3-43a2-8ead-9fe9afbe3d86
⛔ Files ignored due to path filters (1)
app/translations.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (3)
TRANSLATIONS.mdapp/src/main/res/values-cs/strings.xmlapp/src/main/res/values-zh-rCN/strings.xml
| <string name="backup_periodic">Periodické zálohy</string> | ||
| <string name="backup_periodic_hint">Pokud tuto možnost povolíte, zálohy budou automaticky vytvářeny ve zvoleném adresáři záloh. Nemusí to fungovat, pokud máte povolený úsporný režim</string> | ||
| <string name="behaviour">Chování</string> | ||
| <string name="biometric_backup_advice">Před povolením nebo vypnutím biometrického zámku se doporučuje exportovat úplnou zálohu všech poznámek, pro případ, že by šifrování přes biometrický zámek selhalo.\n</string> |
Contributor
There was a problem hiding this comment.
Drop the embedded \n escapes from these user-visible messages.
These new values add explicit leading/trailing newlines, so the Czech locale will render stray blank lines in progress and truncation messages.
Suggested fix
- <string name="biometric_backup_advice">Před povolením nebo vypnutím biometrického zámku se doporučuje exportovat úplnou zálohu všech poznámek, pro případ, že by šifrování přes biometrický zámek selhalo.\n</string>
+ <string name="biometric_backup_advice">Před povolením nebo vypnutím biometrického zámku se doporučuje exportovat úplnou zálohu všech poznámek, pro případ, že by šifrování přes biometrický zámek selhalo.</string>
- <string name="migration_splitting_notes">\nRozdělování příliš velkých poznámek…\n </string>
+ <string name="migration_splitting_notes">Rozdělování příliš velkých poznámek…</string>
- <string name="note_text_too_long_truncated">Text překročil délku, zkráceno na %1$d znaků\n</string>
+ <string name="note_text_too_long_truncated">Text překročil délku, zkráceno na %1$d znaků</string>
- <string name="note_too_big_truncating">Poznámka je příliš velká na uložení, byla zkrácena na %1$s znaků (původně: %2$s)\n</string>
+ <string name="note_too_big_truncating">Poznámka je příliš velká na uložení, byla zkrácena na %1$s znaků (původně: %2$s)</string>Apply the same cleanup to each notes_too_big_truncating plural item.
Also applies to: 250-275
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/src/main/res/values-cs/strings.xml` at line 47, Remove the embedded "\n"
escapes from user-visible Czech strings so they don’t render stray blank lines:
edit the string resource named "biometric_backup_advice" to drop the trailing
"\n" and similarly remove any leading/trailing "\n" escapes from each plural
item under "notes_too_big_truncating" in the Czech locale (the plural entries
around the 250–275 region) so the messages render without extra blank lines.
| <string name="text_default">Výchozí</string> | ||
| <string name="text_size_note_editor">Velikost písma (editor poznámek)</string> | ||
| <string name="text_size_overview">Velikost písma (přehled)</string> | ||
| <string name="text_size">Velikost písma</string> |
Contributor
There was a problem hiding this comment.
Keep the old text-size labels localized until the code switches over.
NotallyXPreferences.kt:35-44 still uses R.string.text_size_note_editor and R.string.text_size_overview. Removing those Czech entries here means those settings labels fall back to the default language.
Suggested fix
<string name="text_default">Výchozí</string>
+ <string name="text_size_note_editor">Velikost písma</string>
+ <string name="text_size_overview">Velikost písma</string>
<string name="text_size">Velikost písma</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <string name="text_size">Velikost písma</string> | |
| <string name="text_default">Výchozí</string> | |
| <string name="text_size_note_editor">Velikost písma</string> | |
| <string name="text_size_overview">Velikost písma</string> | |
| <string name="text_size">Velikost písma</string> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/src/main/res/values-cs/strings.xml` at line 352, The Czech strings.xml
removed the older text-size labels required by NotallyXPreferences.kt; restore
localized entries for the two resource names used there (text_size_note_editor
and text_size_overview) so those keys remain available until the code switches
to the new key (text_size). Update the values in values-cs/strings.xml to
include <string name="text_size_note_editor">…</string> and <string
name="text_size_overview">…</string> (localized Czech text) so
R.string.text_size_note_editor and R.string.text_size_overview referenced by
NotallyXPreferences.kt continue to resolve.
Crustack
force-pushed
the
translation/update
branch
from
6a0cbe1 to
804f68a
Compare
Crustack
force-pushed
the
translation/update
branch
from
7587e02 to
a0c4c6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #893
Closes #897
Closes #922
Summary by CodeRabbit