refactor(web): use arrow functions and enforce func-style#18
Merged
Conversation
Convert every function declaration in src/ to a const-assigned arrow function: React components, hooks, module helpers, and test helpers. The issuingFanOut fixture builder is moved above mockNodes so the const is initialized before the module-level array that spreads it. Add the func-style ESLint rule (expression) so any future function declaration fails lint. Behavior, markup, styles, and logic are unchanged.
Contributor
Author
|
Converted 43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Standardize function definitions across the Fleet Manager UI on arrow-function expressions and enforce the style with ESLint, so the codebase stays consistent and aligns with
@the-rabbit-hole/eslint-config(which now shipsfunc-style: ["error", "expression"]).43
functiondeclarations across 20 files insrc/were converted toconst-assigned arrow functions: React components, context providers/hooks (ThemeProvider/useTheme,AuthProvider/useAuth), module helpers, and test helpers. Insrc/lib/mock.ts,issuingFanOutwas moved abovemockNodesto avoid a temporal-dead-zone error now that it is aconst. No JSX, styles, logic, or Apache headers changed.func-style: ["error", "expression"]was added toeslint.config.js.Closes #17
Verification
How this was verified
npm run build(tsc -b && vite build) — cleannpm run lint(eslint . && prettier --check .) — clean; 0functiondeclarations remain insrc/npm test(vitest run) — 7 passed / 3 filestask license— 0/36 changed