fix(mcp): wire CaptureLog + ConfigDir in buildDeps for capture history#116
Merged
Merged
Conversation
CaptureService.CaptureLog stayed nil and LifecycleService.ConfigDir empty
because buildDeps never set them. Capture writes succeeded against
envector (records appeared in the team index) but capture_log.jsonl never
got appended (capture.go:155 skips Append when CaptureLog is nil), and
CaptureHistory tried to read "capture_log.jsonl" relative to the process
cwd via filepath.Join("", logio.DefaultFilename).
buildDeps now resolves ~/.rune via config.RuneDir() (with $HOME fallback
so handler dispatch never panics during boot), constructs a logio.New
pointed at ~/.rune/capture_log.jsonl, and injects it into both services.
Surfaces the missing wiring noticed during local-smoke end-to-end
verification: 6 records present in the envector index but
/rune:capture_history empty.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CaptureService.CaptureLog stayed nil and LifecycleService.ConfigDir empty because buildDeps never set them. Capture writes succeeded against envector (records appeared in the team index) but capture_log.jsonl never got appended (capture.go:155 skips Append when CaptureLog is nil), and CaptureHistory tried to read "capture_log.jsonl" relative to the process cwd via filepath.Join("", logio.DefaultFilename).
buildDeps now resolves ~/.rune via config.RuneDir() (with $HOME fallback so handler dispatch never panics during boot), constructs a logio.New pointed at ~/.rune/capture_log.jsonl, and injects it into both services.
Surfaces the missing wiring noticed during local-smoke end-to-end verification: 6 records present in the envector index but /rune:capture_history empty.