Skip to content

fix(mcp): support partial readiness and align embedder Info cache with real state#139

Merged
esifea merged 3 commits into
CryptoLabInc:feat/go-migrationfrom
esifea:fix/esifea/boot-and-info-cache
May 20, 2026
Merged

fix(mcp): support partial readiness and align embedder Info cache with real state#139
esifea merged 3 commits into
CryptoLabInc:feat/go-migrationfrom
esifea:fix/esifea/boot-and-info-cache

Conversation

@esifea

@esifea esifea commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • What changed:
    • Boot injects each adapter as it becomes ready
    • Embedder Info cache stores only success
  • Why:
    • /rune:diagnostics cannot check partial readiness with all-or-nothing approach
    • Info cache is never updated with sync.Once
  • Scope:

Validation

  • Tests run (or explain why not):
  • Docs updated (if behavior/setup changed)

Cross-Agent Invariants

  • scripts/bootstrap-mcp.sh remains the single source of truth for runtime prep (venv/deps/self-heal)
  • No agent-specific script duplicates bootstrap/setup logic
  • Agent-specific scripts remain thin adapters (registration/wiring only)
  • Codex-only commands (codex mcp ...) are clearly separated from cross-agent/common instructions
  • Claude/Gemini/OpenAI instructions do not include Codex-only commands
  • SKILL.md, commands/rune/*.toml, and AGENT_INTEGRATION.md stay consistent on boundaries

Notes for Reviewers

  • Risk areas:
  • Backward compatibility impact:
  • Follow-up work (if any): staleClientCloseTime is changed to 30s to avoid race, but it should be reverted once closeAfterInterval is implemented with refcount/WaitGroup

@esifea esifea self-assigned this May 19, 2026
@esifea
esifea marked this pull request as ready for review May 19, 2026 06:01
@esifea
esifea requested a review from couragehong May 19, 2026 06:01
@esifea
esifea force-pushed the fix/esifea/boot-and-info-cache branch from aea9bdf to 4652393 Compare May 19, 2026 06:50
Comment thread internal/adapters/embedder/cache.go
@esifea
esifea merged commit 7ec43a5 into CryptoLabInc:feat/go-migration May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants