fix: remove credential env overrides#45
Merged
Merged
Conversation
added 3 commits
March 30, 2026 19:18
heeyeon01
force-pushed
the
fix/remove-credential-env-overrides
branch
from
March 30, 2026 11:26
bbbde37 to
e8a6aaa
Compare
heeyeon01
force-pushed
the
fix/remove-credential-env-overrides
branch
7 times, most recently
from
March 31, 2026 06:39
ae527e1 to
2ad95a7
Compare
heeyeon01
marked this pull request as ready for review
March 31, 2026 08:11
heeyeon01
requested review from
couragehong,
esifea,
jh-lee-cryptolab and
sunchuljung
March 31, 2026 08:11
esifea
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/rune:configure.reload_pipelinesnow correctly picks up updated credentials fromconfig.jsonwithout requiring a session restart.load_config()docstring to reflect that vault/envector credentials are loaded exclusively fromconfig.json.Context
/rune:configurecollects Vault and enVector credentials and writes them to~/.rune/config.json.reload_pipelinestool that re-readsconfig.jsonat runtime, allowing credential updates to take effect without restarting the session.Problem
load_config()applied environment variable overrides forRUNEVAULT_ENDPOINT,RUNEVAULT_TOKEN,VAULT_CA_CERT,VAULT_TLS_DISABLE,ENVECTOR_ENDPOINT, andENVECTOR_API_KEYafter reading the config file.reload_pipelinescall, causing reconfiguration to have no effect and producing a misleading "Vault key fetch failed" error that suggested a permissions problem.agents/common/config.pyagents/tests/test_config.pyValidation
TestCredentialOverrideConfigclassAdded 12 parametrized test cases covering all 6 removed env vars
test_credential_not_overridden_by_env— env var present but config.json value winstest_reload_picks_up_reconfigured_credential— secondload_config()call (simulatingreload_pipelines) reflects updated file valueCross-Agent Invariants
scripts/bootstrap-mcp.shremains the single source of truth for runtime prep (venv/deps/self-heal)codex mcp ...) are clearly separated from cross-agent/common instructionsSKILL.md,commands/rune/*.toml, andAGENT_INTEGRATION.mdstay consistent on boundariesNotes for Reviewers