Fix bugs, get ready for v1 - #2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens up a form-handling edge case in the Clubs UI and pins js-yaml via pnpm overrides to ensure consistent dependency resolution as the project approaches v1.
Changes:
- Capture the form element before async work so the success callback can reliably reset the form.
- Add a pnpm override to pin
js-yamlto4.3.1. - Update the pnpm lockfile to reflect the overridden
js-yamlversion.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/pages/clubs-page.tsx | Stores event.currentTarget in a local form variable so the post-action callback can reset the form reliably. |
| frontend/pnpm-workspace.yaml | Adds a pnpm overrides entry to pin js-yaml to 4.3.1. |
| frontend/pnpm-lock.yaml | Updates lockfile overrides and resolved package entries to js-yaml@4.3.1. |
Files not reviewed (1)
- frontend/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 |
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.