Skip to content

Add workspaces, admin#9

Merged
sboh1214 merged 3 commits into
mainfrom
workspace
Aug 19, 2021
Merged

Add workspaces, admin#9
sboh1214 merged 3 commits into
mainfrom
workspace

Conversation

@sboh1214

Copy link
Copy Markdown
Collaborator

image

@sboh1214
sboh1214 requested a review from buttercrab August 17, 2021 17:42
@sboh1214 sboh1214 self-assigned this Aug 17, 2021
@sboh1214
sboh1214 requested a review from minchurl August 18, 2021 07:55
@buttercrab
buttercrab requested a review from utilForever August 18, 2021 10:49

@buttercrab buttercrab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run npm i before commit

@sboh1214
sboh1214 requested a review from buttercrab August 18, 2021 14:48
buttercrab
buttercrab previously approved these changes Aug 18, 2021

@buttercrab buttercrab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@833b0e5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   33.33%           
=======================================
  Files           ?        3           
  Lines           ?        9           
  Branches        ?        0           
=======================================
  Hits            ?        3           
  Misses          ?        6           
  Partials        ?        0           

utilForever
utilForever previously approved these changes Aug 18, 2021

@utilForever utilForever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that we should add new members next time. 🕊️

Comment thread .gitignore Outdated
Comment thread auth/Cargo.toml Outdated
Comment thread game/Cargo.toml Outdated
Comment thread middleware/Cargo.toml Outdated
@sboh1214
sboh1214 dismissed stale reviews from utilForever and buttercrab via 464e3a1 August 19, 2021 01:54

@utilForever utilForever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. 🐦

@sboh1214
sboh1214 merged commit 5a93a06 into main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants