feat(peek): document the assisted-apply "re-verify" step#123
Merged
Conversation
…loop (H3.1 Slice A) Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
…(H3.1 Slice A) Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
…1 Slice A) Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds apply-and-re-verify guidance to the MCP server's ChangesAssisted-apply re-verify guidance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peek's supervised assisted-apply loop (control shield + input handoff +
set_intentbanner + published recipe) already ships. What it didn't yet spell out is the "…and re-verify" half of "apply this fix and re-verify." This adds that convention — guidance only, no new tool/permission/behavior.SERVER_INSTRUCTIONS+execute_action+set_intentdescriptions): after a mutating action, re-read the target withget_element_detail(its value should match what you intended) andget_page_view(no validation error should have appeared) before advancing the status banner; if it didn't take, stop and report viaset_intentrather than blind-retrying.assisted-apply-with-supervision): a new "Verifying each applied step" section + a Step-3 pointer (+updatedAtbump).password/email/PII field values come back masked (the same masking the recorder applies), so those are verified by the absence of an error, not by value — consistent with the existingget_element_detail/get_page_viewdocs.The loop stays client-driven (the agent orchestrates already-shipped read tools); no server-side loop primitive is added (that would be the autonomous-agent drift the project deliberately avoids).
execute_actionremains consent-gated + destructive-overridden + audit-logged.Test Plan
stdio-smokeasserts the 16 tool names/count (descriptions aren't asserted); full@peekdev/mcpsuite green (366/1 skip) with peek-mcp built so the smoke test runs.peek-docsbuild validates the recipe frontmatter (descriptionuntouched at 153/160;updatedAtparses as a date);verify-recipespasses.@peekdev/mcppatch.Post-merge: peek-docs has no auto-deploy — the recipe change needs a manual Vercel redeploy.
Summary by CodeRabbit