docs(peek): correct MCP tool count (10 → 14) + permission model#94
Conversation
The peek MCP server now registers 14 tools, but the docs/comments still
described the original 10-tool read surface:
- 8 read tools, + act (execute_action, request_authorization),
+ Suggest (suggest_element, clear_highlight, Level 2),
+ control (set_intent, request_user_input, Level 4).
Updated: peek-mcp/README.md tool table + the "Level 2 highlight … queued" line
(now shipped); peek-cli/README.md; the Claude Code skill (count in 3 places +
expanded tool tables); server.ts header comment ("not registered here" was
false) + the createPeekMcpServer docstring; and the three MCP-registry
distribution templates (count + tool lists).
Also corrects the skill's permission model — it described a wrong 6-level (0–5)
scheme with the wrong default (Level 0) and wrong storage (~/.peek/permissions.json).
Now matches ADR-0010: 5 levels (0 Off · 1 Read-only default · 2 Suggest ·
3 Act-with-confirm · 4 YOLO), stored in chrome.storage.sync; the destructive
blocklist is a cross-level override, not a Level 5. Read tools work at Level 1+,
not 2+.
Docs/comment only; no code change. CHANGELOG (frozen) left untouched.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: harry-harish <22562634+harry-harish@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughDocumentation-only update that corrects the stated MCP tool count from 10 to 14 across all READMEs, distribution docs, and ChangesMCP Tool Count and Permission Model Documentation Corrections
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The peek MCP server registers 14 tools, but the docs + a code comment still described the original 10-tool read-only surface ("writes are Phase 3d — not registered here"). This corrects every stale reference, found via a literal sweep plus a semantic check that caught tool tables/sections missing the newer tools.
The actual surface (verified against
server.ts+levels.ts)Files fixed
packages/peek-mcp/src/mcp/server.ts— header comment ("seven session/query tools… not registered here") + thecreatePeekMcpServerdocstring ("all Level-1 read tools").packages/peek-mcp/README.md— tool table (added the 4 missing tools) + the stale "Level 2 highlight … queued" line (now shipped).packages/peek-cli/README.md— "exposes 10 tools" → 14 (+ mentions highlight & input handoff).packages/peek-cli/skills/peek-skill.md— count in 3 places; expanded the tool tables into Read/Act/Suggest/Control; and rewrote the permission model, which described a wrong 6-level (0–5) scheme with the wrong default (Level 0) and wrong storage path (~/.peek/permissions.json).docs/peek/distribution/{claude-code-skill,modelcontextprotocol-servers,mcp-so}.md— count + registry-listing tool lists (so future submissions are accurate).Permission-model correction (ADR-0010 ground truth)
The skill now matches the code: 5 levels —
0 Off · 1 Read-only(default)· 2 Suggest-only · 3 Act-with-confirm · 4 YOLO this session. Levels live inchrome.storage.sync(peek:permissionLevels), not a JSON file. Read tools work at Level 1+ (the skill wrongly said 2+). The destructive-action blocklist is a cross-level override, not a "Level 5".Verification
peek-mcp/CHANGELOG.md"exposes 10 tools" entry was left untouched (historical record).🤖 Generated with Claude Code
Summary by CodeRabbit