Skip to content

network-quality.yml: suggest-repairs is skipped exactly when the audit finds something to repair #318

Description

@realmarcin

Found reviewing PR #316.

suggest-repairs:
  needs: audit-network
  if: ${{ github.event_name == 'workflow_dispatch' && inputs.suggest_repairs }}

A job with needs: is skipped when the needed job fails, and this if: carries no always() / !cancelled(). While audit-network was reporting-only it always ran; now that #316 restored the hard gate, any error-severity finding fails audit-network and skips suggest-repairs.

So the LLM repair-suggestion feature — whose entire purpose is proposing fixes for these findings — can now only run when there is nothing to fix.

Failure scenario: someone lands a dangling downstream.target, then dispatches the workflow with suggest_repairs: true to get suggestions. The job never starts.

Fix: if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' && inputs.suggest_repairs }}.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions