You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found reviewing PR #372. The general form of #373.
gtdb_ground.py grounds a higher-rank NCBI taxon to whichever GTDB taxon holds the most genomes. GTDB, however, assigns names by nomenclatural type: the lineage containing the type species keeps the unsuffixed name, and the rest take alphabetic suffixes.
These rules disagree whenever a non-type clade is more heavily sequenced. Verified against GTDB R226 for all five taxa where the two denominators differ:
taxon
grounded to
type species
type sits in
Enterococcus
g__Enterococcus_B
E. faecalis
g__Enterococcus
Pseudomonas
g__Pseudomonas
P. aeruginosa
g__Pseudomonas ✓
Acetobacter
g__Acetobacter
A. aceti
g__Acetobacter ✓
Leptospirillum
g__Leptospirillum
L. ferrooxidans
g__Leptospirillum ✓
Bacillus
g__Bacillus
B. subtilis
g__Bacillus ✓
Four of five agree by luck rather than by construction — the majority happens to be the type clade. Only Enterococcus diverges today, but nothing prevents the others from flipping as sequencing depth shifts.
Options:
Prefer the type-anchored clade when the NCBI name has an unsuffixed GTDB counterpart — arguably what "grounding NCBI genus X" should mean.
Flag the disagreement rather than resolve it: emit the majority answer but mark that it is not the type clade, so a curator sees it.
Found reviewing PR #372. The general form of #373.
gtdb_ground.pygrounds a higher-rank NCBI taxon to whichever GTDB taxon holds the most genomes. GTDB, however, assigns names by nomenclatural type: the lineage containing the type species keeps the unsuffixed name, and the rest take alphabetic suffixes.These rules disagree whenever a non-type clade is more heavily sequenced. Verified against GTDB R226 for all five taxa where the two denominators differ:
g__Enterococcus_Bg__Enterococcusg__Pseudomonasg__Pseudomonas✓g__Acetobacterg__Acetobacter✓g__Leptospirillumg__Leptospirillum✓g__Bacillusg__Bacillus✓Four of five agree by luck rather than by construction — the majority happens to be the type clade. Only Enterococcus diverges today, but nothing prevents the others from flipping as sequencing depth shifts.
Options:
Option 2 is cheap and loses nothing; option 1 changes semantics and deserves a decision.