You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Raised in review of PR #329 and split out at the reviewer's suggestion rather than
growing that PR further. Not fixed there — but deliberately not silent either: the reduces row in mappings/predicate_grounding.tsv now documents both senses and links
here, so it does not land as unexamined precedent.
The problem
METPO:2007802 (reduces, proposed in proposals/metpo_traitmech_v9) is defined as:
asserts that the subject donates electrons to the object, lowering its oxidation state
30 corpus edges carry it, and they are two different senses:
The second group asserts something false under the term's definition — membrane lipid
remodelling does not donate electrons to proton leakage. Full list of the "lessens" group:
ecology/gut_associated.yaml — intestinal peristalsis → colonization/retention in duodenum
Note oxygenic_photosynthesis.yaml's photosystem I --reduces--> ferredoxin is genuinely
redox despite its non-chemical object, so "object is not a CHEMICAL" is not a safe
classifier — this needs reading per edge.
Why (predicate_id, label) cannot separate them
The migration script keys on that pair precisely because METPO:2000013 is reached from
two labels with opposite directions (#327). Here the label is identical — both senses
are written reduces — so no key over the existing data distinguishes them. Fixing it
requires a corpus relabel first.
Suggested fix
Relabel the ~11 "lessens" edges to a distinct predicate grounded to RO:0002212
(negatively regulates), which already has a row in mappings/predicate_grounding.tsv.
Each needs reading — several may be better served by RO:0002212 vs a "decreases
quantity of" sense.
Narrow the reduces row's subject_types/object_types to the redox shape once the
others have moved.
proposals/metpo_traitmech_v9/metpo_proposal_properties_robot.tsv — the METPO:2007802 definition_source cited the non-redox peristalsis edge as its exemplar. Fixed in Migrate the remaining microbe-domain edges (#301, part 2 of 2) #329 so the upstream artifact does not carry a wrong exemplar, but noted here for
completeness.
Related: #327 (the other predicate whose corpus usage does not match its term's sense).
Raised in review of PR #329 and split out at the reviewer's suggestion rather than
growing that PR further. Not fixed there — but deliberately not silent either: the
reducesrow inmappings/predicate_grounding.tsvnow documents both senses and linkshere, so it does not land as unexamined precedent.
The problem
METPO:2007802(reduces, proposed inproposals/metpo_traitmech_v9) is defined as:30 corpus edges carry it, and they are two different senses:
terminal_oxidases --reduces--> molecular_oxygenmembrane_lipid_remodeling --reduces--> inward_proton_leakageThe second group asserts something false under the term's definition — membrane lipid
remodelling does not donate electrons to proton leakage. Full list of the "lessens" group:
ecology/gut_associated.yaml— intestinal peristalsis → colonization/retention in duodenumenvironment/acidotolerant.yaml— membrane lipid remodeling → inward proton leakageenvironment/facultatively_acidophilic.yaml— hopanoid biosynthesis → membrane proton permeabilityenvironment/nacl_range.yaml— cyclic di-AMP → high-salt toleranceenvironment/ph_delta_high.yaml— membrane lipid/porin composition changes → inward proton leakageenvironment/ph_delta_mid3.yaml— membrane lipid composition shifts → membrane proton permeabilityenvironment/ph_range_very_low.yaml— inside-positive membrane potential → passive proton influxenvironment/temperature_optimum_high.yaml— positive DNA supercoiling → DNA melting at high temperaturegenomics/plasmid_carriage.yaml— compensatory mutation → plasmid fitness costmorphology/gram_variable.yaml— thin peptidoglycan layer → CV-iodide complex retentionphysiology/oligotrophic.yaml— streamlined genome → reduced metabolic redundancyNote
oxygenic_photosynthesis.yaml'sphotosystem I --reduces--> ferredoxinis genuinelyredox despite its non-chemical object, so "object is not a CHEMICAL" is not a safe
classifier — this needs reading per edge.
Why
(predicate_id, label)cannot separate themThe migration script keys on that pair precisely because
METPO:2000013is reached fromtwo labels with opposite directions (#327). Here the label is identical — both senses
are written
reduces— so no key over the existing data distinguishes them. Fixing itrequires a corpus relabel first.
Suggested fix
RO:0002212(negatively regulates), which already has a row in
mappings/predicate_grounding.tsv.Each needs reading — several may be better served by
RO:0002212vs a "decreasesquantity of" sense.
reducesrow'ssubject_types/object_typesto the redox shape once theothers have moved.
proposals/metpo_traitmech_v9/metpo_proposal_properties_robot.tsv— theMETPO:2007802definition_sourcecited the non-redox peristalsis edge as its exemplar. Fixed inMigrate the remaining microbe-domain edges (#301, part 2 of 2) #329 so the upstream artifact does not carry a wrong exemplar, but noted here for
completeness.
Related: #327 (the other predicate whose corpus usage does not match its term's sense).