cuprated: get_info, syncer improvements - #653
Merged
Merged
Conversation
redsh4de
force-pushed
the
fix/syncer-status
branch
2 times, most recently
from
July 13, 2026 07:22
21bcb81 to
27955cc
Compare
redsh4de
marked this pull request as ready for review
July 13, 2026 09:02
redsh4de
force-pushed
the
fix/syncer-status
branch
2 times, most recently
from
July 14, 2026 20:05
b9f8a89 to
02f0cb9
Compare
redsh4de
force-pushed
the
fix/syncer-status
branch
from
July 19, 2026 22:07
8b6da96 to
ee0ea20
Compare
Boog900
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improves sync-status updates and fixes a race in get_info
Why
The previous implementation had a couple shortcomings:
get_inforead the target height separately forbusy_syncingandtarget_height, so an update between those reads could produce a conflicting response.monerodalso performs separate sync-state reads in get_info (race prone), so we avoid it by readingtarget_heightonce at the top, then derivebusy_syncingandsynchronizedfrom it.Where
cuprated,p2p-coreHow
target_heightonce at the top,busy_syncingandsynchronizedbecome derivatives of it