test(bench): execute SNB Interactive IS1 through live GraphForge - #1084
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Caller-provided rows can no longer reach a public live-named API. Trusted evidence now asserts the complete identity, parameter, and checksum bind. Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
9256492 to
b5a6f64
Compare
The SNB Interactive adapter previously validated replayed files without proving public GraphForge execution. Add a bounded live IS1 lane whose Rust runner loads the pinned synthetic fixture through the public facade, warms and executes the parameterized query, and validates its Arrow results against the declared reference.
Live evidence is runner-owned and binds the fixture, job, reference, acquisition, identity, parameters, and execution phases. Preserve column boundaries, empty strings, and whitespace during comparison; an adversarial regression modifies a real engine result to prove merged or shifted fields cannot falsely pass.
IS1 is the live proof. IS2–IS7 and IC1–IC13 remain explicitly labeled static/reference replay coverage. IC14 and IU1–IU8 retain typed unsupported outcomes. The fixture is synthetic engineering data, not official Datagen scale-factor output, and evidence explicitly denies audited certification. This PR does not claim full-suite live execution.
Validation on the integrated tree:
make -C benchmarks smoke: passed, including 381 Python tests, all Rust runner tests (14 SNB Interactive tests), benchmark workspace Clippy, formatting, and the Cargo dependency-boundary check.make pre-push-fastand final formatting/diff checks: passed.Closes #962. #952 remains the broader M11 completion gate. Exact-head CI run 33946967997 passed at
b5a6f64303c90d059f5fa383a458765db7b00aae, with CI Gate successful, CLEAN merge state, and no unresolved review threads. Squash merged as88fb033726042cb9b5fec9ce0b5259f3dd73e12f; issue #962 is closed.