Subroutine within a subroutine using arguments

[kakariki1]

Hello CurlyMoo,

I'm not sure if I just made a mistake or found an issue, please have a look:

I downloaded and compiled your library and had the unittest run on a ESP8266.
It works perfectly fine.

Then I added following unittest:
{ "on sub2($a) then print($a); end on sub1($a) then print($a); sub2(2); end on main then sub1(1); end", { { NULL, 0 } }, { { NULL, 0 } }, 0 }

This does not run and I get following error:
ERROR: Unexpected token (3187)

Can you please have a look ?
I want to call a subroutine within a subroutine using arguments ...

Many thanks,
lakeroe

[CurlyMoo]

Good catch, I'm not sure if I incorporated this feature in the first place.

[kakariki1]

Do you have any ambitions to fix this ?

[CurlyMoo]

When i can find time.

[kakariki1]

Thanks a lot ;-)

[CurlyMoo]

I also fixed this one.

[kakariki1]

Wow, what a nice surprise.

If you're interrested I found more inconsistencies between int and uint variables.

int / uint inconsistency
Line 1671: uint32_t vm_heap_push ...
Line 2116: int16_t e = 0;
Line 2157: e = vm_heap_push(obj, VNULL, NULL, 0, 0, 1);

int / uint and 8 / 16 bit inconsistency
Line 1429: static int16_t vm_val_pos(int8_t pos) {
Line 4214: uint8_t a = vm_val_pos((int8_t)getval(node->a));
Line 4215: uint8_t b = vm_val_pos((int8_t)getval(node->b));
Line 4216: uint8_t c = vm_val_pos((int8_t)getval(node->c));
Line 4542: uint8_t a = vm_val_pos((int8_t)getval(node->a));

8 / 16 bit inconsistency
Line 2144: int8_t b = vm_val_pos((int8_t)getval(x->b));
Line 2145: int8_t c = vm_val_pos((int8_t)getval(x->c));

int / uint inconsistency
Line 4599: uint16_t a = vm_val_pos(getval(node->a));
Line 4707: uint16_t b = vm_val_pos((int8_t)getval(node->b));
Line 4796: uint16_t a = vm_val_pos((int8_t)getval(node->a));
Line 4828: uint16_t a = vm_val_pos((int8_t)getval(node->a));

I think there are still more inconsistencies existing.
I have no idea if they are a real issue or not, but if you really want a perfect source code you should have a deeper look ...

Best regards and a happy new year.

[CurlyMoo]

Can you open a new issue with the new findings?

[kakariki1]

done