New Windows Unicode solution, works on XP#335
Merged
Conversation
Now uses WriteConsoleW instead of vfwprintf. This is codepage independent and works on Windows XP. Doing this also avoids the _O_U8TEXT hack.
Helps when you set your guideline to the correct column.
Contributor
Author
|
Truly fixes #293. |
|
Err… I’m a mere user without compiler. Could I have a binary to verify the fix, please? |
Contributor
Author
|
Oh, so many binaries, it makes me confused all the time. Right, I confirm that |
Contributor
Author
|
I might have used the wrong filename, or MSVC builds just don't work with XP. I'll test in my VM later. Edit: Forgot that MSVC sets the minimum version to NT 6.0 a.k.a. Vista. You need to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now uses
WriteConsoleWinstead ofvfwprintf. This is codepage independent and works on Windows XP.Doing this also avoids the
_O_U8TEXThack.Also use
_vsnprintfinstead ofvsnprintf, as it is more consistent thanvsnprintfin that it doesn't write the null terminator on truncation. Weird.Some minor cleanup was done as well.