docs(paper): clarify local estimator API in Software Design - #131
Merged
Conversation
Local estimators do not share predict_dte/predict_pte/predict_qte with the other estimators; they expose predict_ldte/predict_lpte for the imperfect-compliance setting. Split the API description accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paper/paper.mdcurrently states that "all estimators implement a consistent API with three primary methods" (predict_dte,predict_pte,predict_qte).SimpleLocalDistributionEstimator,AdjustedLocalDistributionEstimator) do not use those methods for their intended estimand — they exposepredict_ldte()andpredict_lpte()for the imperfect-compliance setting.Test plan
🤖 Generated with Claude Code