Conversation
be65dd5 to
a1ecebc
Compare
a1ecebc to
8e2feb5
Compare
8e2feb5 to
08adc3a
Compare
madpah
left a comment
There was a problem hiding this comment.
Hey @jkowalleck - like the idea. Thanks for the PR.
Can you also add a documentation update to explain this new invocation method as per #321 ?
Also - would we consider this a breaking change given PEP-3102 syntax has been added?
|
Sure, will add docs in the readme and other places. Re: breaking change. |
|
actually, i do not have any idea where i could document the call via regarding "is this a breaking change?" |
|
@jkowalleck - I've added Documentation to CONTRIBUTING.md now - let me know if that is not enough to pop in some documentation changes. Thanks on confirming NO breaking change 👍 |
|
Thanks, @madpah . Could you point me to the spot i could update, @madpah ? I can't see the forest for the trees. |
fixes #321 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
08adc3a to
2bac83a
Compare
|
added the missing docs. made creative modification in the "usage" section, as this is the related topic. is this fine, @madpah ? |
|
@madpah please have a look at the proposed changes of this PR |
fixes #321