Skip to content

feat: make package/module callable#326

Merged
madpah merged 2 commits intomasterfrom
callable-module
Apr 5, 2022
Merged

feat: make package/module callable#326
madpah merged 2 commits intomasterfrom
callable-module

Conversation

@jkowalleck
Copy link
Member

fixes #321

@jkowalleck jkowalleck requested a review from a team as a code owner March 3, 2022 08:18
@jkowalleck jkowalleck requested a review from madpah March 3, 2022 08:19
@jkowalleck jkowalleck force-pushed the callable-module branch 2 times, most recently from be65dd5 to a1ecebc Compare March 3, 2022 12:22
@jkowalleck jkowalleck marked this pull request as draft March 3, 2022 12:25
@jkowalleck jkowalleck marked this pull request as ready for review March 3, 2022 12:27
@jkowalleck jkowalleck changed the title feat: make module callable feat: make package/module callable Mar 5, 2022
Copy link
Collaborator

@madpah madpah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jkowalleck - like the idea. Thanks for the PR.

Can you also add a documentation update to explain this new invocation method as per #321 ?

Also - would we consider this a breaking change given PEP-3102 syntax has been added?

@jkowalleck
Copy link
Member Author

Sure, will add docs in the readme and other places.

Re: breaking change.
My intention was to add optional params to existing public api, so full backwards compatibility is given. Will check if I can improve the implementation.
Do you have any advice? Could you share your thoughts, @madpah ?

@jkowalleck
Copy link
Member Author

jkowalleck commented Mar 8, 2022

actually, i do not have any idea where i could document the call via python -m. Please point me to it, @madpah .

regarding "is this a breaking change?"
A: nope, it still adds optional parameters to existing methods. No issue with backwards-compatibility, as the functionality is optional and usage is self-contained.

@madpah
Copy link
Collaborator

madpah commented Mar 9, 2022

@jkowalleck - I've added Documentation to CONTRIBUTING.md now - let me know if that is not enough to pop in some documentation changes.

Thanks on confirming NO breaking change 👍

@jkowalleck
Copy link
Member Author

Thanks, @madpah .
I still do not know where to document alternative call methods.
I see https://github.com/CycloneDX/cyclonedx-python/blob/master/docs/usage.rst talking about the params and such. and is points out to call cyclonedx-bom. But where is the note that cyclonedx-py for example is an alternative call method? I would add the python -m cyclonedx-py at the exact same spot.

Could you point me to the spot i could update, @madpah ? I can't see the forest for the trees.

fixes #321

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from madpah March 11, 2022 17:47
@jkowalleck
Copy link
Member Author

jkowalleck commented Mar 11, 2022

added the missing docs. made creative modification in the "usage" section, as this is the related topic.

is this fine, @madpah ?

@jkowalleck
Copy link
Member Author

@madpah please have a look at the proposed changes of this PR

@madpah madpah merged commit 193f1a4 into master Apr 5, 2022
@madpah madpah deleted the callable-module branch April 5, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: make cli available as a python module

2 participants