fix(xml): allow protocol cryptographic relationships - #1019
Open
qkaiser wants to merge 1 commit into
Open
Conversation
The CycloneDX 1.7 JSON Schema is the reference implementation and defines relatedCryptographicAssets on protocol properties. Protobuf exposes the same relationship, but the XML schema omitted it, leaving the three representations inconsistent and preventing valid protocol relationships from passing XSD validation. Add the preferred relationship collection after the deprecated cryptoRef elements, matching the existing certificate and related-material XML structures. Clarify that cryptoRef is deprecated, and exercise the same protocol-to-public-key relationship in the XML, JSON, and Protobuf full cryptography examples. Signed-off-by: Quentin Kaiser <quentin.kaiser@onekey.com>
qkaiser
force-pushed
the
fix-cbom-specs-xsd
branch
from
August 13, 2026 08:53
9ff9100 to
63cda28
Compare
CAOShurong
approved these changes
Aug 13, 2026
CAOShurong
left a comment
CAOShurong
left a comment
There was a problem hiding this comment.
I compared this exact head (63cda281ab834726ca1b80c480fa9edf9693d4f0) with my later duplicate #1020 and independently reran the relevant validation. The XSD structure implements the same cross-format fix, and this version also clarifies the deprecation of cryptoRef.
Verified on this head:
mvn clean test: 769 tests passednpm testwith Node 24.19.0 on Linux paths: passed- Buf 1.58.0 schema lint: passed
- the modified 1.7 cryptography textproto fixture converted successfully against
cyclonedx.v1_7.Bom
I did not rerun the PHP or documentation-generation workflows in this review. I am approving this earlier implementation and will close my later duplicate #1020.
OpenAI Codex assisted with the comparison and test execution; I reviewed the diff and the observed outputs and take responsibility for this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CycloneDX 1.7 JSON Schema is the reference implementation and defines relatedCryptographicAssets on protocol properties. Protobuf exposes the same relationship, but the XML schema omitted it, leaving the three representations inconsistent and preventing valid protocol relationships from passing XSD validation.
Add the preferred relationship collection after the deprecated cryptoRef elements, matching the existing certificate and related-material XML structures. Clarify that cryptoRef is deprecated, and exercise the same protocol-to-public-key relationship in the XML, JSON, and Protobuf full cryptography examples.
Fixes #1018