Fix Menril Resin and Liquid Chorus fluids being non-interactable in world#1658
Merged
rubensworks merged 4 commits intomaster-26from Apr 13, 2026
Merged
Fix Menril Resin and Liquid Chorus fluids being non-interactable in world#1658rubensworks merged 4 commits intomaster-26from
rubensworks merged 4 commits intomaster-26from
Conversation
…ushReaction properties to fluid block configs Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/552eeed1-70cb-4522-b7d9-c1ed2444e6cb Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
…ion in fluid game tests Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/552eeed1-70cb-4522-b7d9-c1ed2444e6cb Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix interaction issues with resin fluid
Fix Menril Resin and Liquid Chorus fluids being non-interactable in world
Apr 12, 2026
rubensworks
requested changes
Apr 12, 2026
| Component.literal("Menril resin fluid block was not placed")); | ||
|
|
||
| // Place a solid block where the fluid is | ||
| helper.setBlock(POS, Blocks.DIRT); |
Member
There was a problem hiding this comment.
Set block as player instead via an itemstack, because calling setBlock like this will not trigger a replaceable check.
Contributor
Author
There was a problem hiding this comment.
Updated in b12dd89 — both replaceable tests now use helper.placeAt(player, dirtStack, POS.south(), Direction.NORTH) which calls ItemStack.useOn() via a UseOnContext, which in turn creates a BlockPlaceContext that checks canBeReplaced() on the fluid block at POS before allowing placement.
…, triggering actual replaceable check Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/466f2fc5-34d9-429c-a672-a72b3931d363 Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both custom fluid blocks were missing block properties required by Minecraft/NeoForge for standard fluid behavior, making it impossible to place blocks in fluid space or pick up fluid with a bucket.
Root cause
BlockFluidMenrilResinConfigandBlockFluidLiquidChorusConfigwere missing four block properties that vanilla fluid blocks (water/lava) require:.replaceable().liquid().pushReaction(PushReaction.DESTROY).noLootTable()Fix
Applied identically to both
BlockFluidMenrilResinConfigandBlockFluidLiquidChorusConfig.Tests
Added
GameTestsFluidswith four game tests covering block replacement andBucketPickup.pickupBlock()for both fluids.