Add printf format attribute to OFFile printf wrappers - #151
Open
hjmjohnson wants to merge 1 commit into
Open
Conversation
OFFile::fprintf and OFFile::vfprintf forward their format parameter to ::vfprintf, which triggers clang/gcc -Wformat-nonliteral in every translation unit that includes offile.h. Annotating the wrappers with __attribute__((format(printf, ...))) marks the parameter as a valid forwarding target and gives callers full format/argument checking.
hjmjohnson
marked this pull request as ready for review
July 12, 2026 21:55
dzenanz
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OFFile::fprintfandOFFile::vfprintfforward theirformatparameter to::vfprintf, which triggers clang/gcc-Wformat-nonliteralin every translation unit that includesoffile.h.Annotating the two wrappers with
__attribute__((format(printf, ...)))(guarded, empty on other compilers) marks the parameter as a valid forwarding target — silencing the wrapper-internal warning — and additionally gives all callers compile-time format/argument checking.Found while building ITK, which vendors DCMTK and compiles with
-Wformat-nonliteralenabled.