Vendor Diva.js v7 alongside v6 with a runtime version switch - #970
Open
etosphere wants to merge 1 commit into
Open
Vendor Diva.js v7 alongside v6 with a runtime version switch#970etosphere wants to merge 1 commit into
etosphere wants to merge 1 commit into
Conversation
As Stage 2 of the Diva v6 -> v7 migration (issue #942), this commit vendors Diva v7.2.2 side-by-side with v6 and wires it into the build, with a runtime switch so v7 can be tested locally without touching the v6 path. DivaAdapter is refactored that delegates to one of two backends chosen at initialize() time via localStorage.setItem("divaBackend", "v7"). DivaBackendV6 is the previous DivaAdapter implementation (the v6 version). DivaBackendV7 is a unfinished implementation that only proves the wiring: OSD 5.0.1 is injected from CDN, the v7 bundle is loaded on demand via a webpack dynamic import (keeping it out of the main bundle on the v6 path), and a Diva v7 viewer mounts over the IIIF manifest. The Cantus-related behaviour (such as events and navigation) is not implemented yet. Diva v7's CSS uses unscoped class names that collide with Bootstrap; gulpfile.mjs now generates a #diva-wrapper-scoped copy from the vendored source files at build time, and DivaBackendV7 suppresses v7's own global style injection using v7's own escape hatch. A height fix in styles.scss ensures v7's flex layout fills the Diva column. This commit contains only source files; the built bundles under nginx/static are not regenerated in this commit.
kyrieb-ekat
approved these changes
Aug 5, 2026
kyrieb-ekat
left a comment
kyrieb-ekat
left a comment
Contributor
There was a problem hiding this comment.
overall looks great; just a quick note that DivaBackendV7 is explicitly a stub in this PR (deliberately doesn't emit viewer:loaded, keeping downstream code dormant) — reasonable staging. One thing to note: backend.initialize() can return a rejected promise (loadOpenSeadragon/loadOpenSeadragon script error, or dynamic import('diva7') failure) and nothing in this PR catches it. It's an unhandled rejection until #971 wraps the call in Promise.resolve(...).catch(...). Probably fine since only devs opting into the v7 flag hit this path at this stage, but worth knowing if #970 is ever merged/deployed on its own.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #964.