ci: gate PRs with Playwright e2e + fix release-branch triggers - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real CI holes, fixed before the 1.0.0 release:
npm test(vitest) + build. That's how the More built-in functions: ROUND(), MOD(), MAX(), MIN(), TIME(), YEAR()/MONTH()/DAY() #4 built-ins shipped broken (unit-green, e2e-red, CI blind).main. Under GitFlow every PR targetsrelease/**, so PRs feat: implement ? / ?? print command (#2) #21–test+fix: parity-line e2e coverage, and fix #4 built-ins unreachable via REPL #25 ran zero automated checks.Changes
.github/workflows/ci.yml: trigger on push/PR tomainandrelease/**; add ane2ejob (playwright install --with-deps chromium→playwright test), uploading the report artifact on failure.playwright.config.ts: add awebServerblock so the suite auto-starts the dev server (required in CI; reuses an already-running server locally). Verified locally —npx playwright testwith no manual server starts one and passes.Targets
release/v1.0.0per GitFlow. This same CI config propagates torelease/v1.1.0when 1.0.0 reaches main.