Merged
Conversation
alexluckett
reviewed
Nov 27, 2025
Contributor
alexluckett
left a comment
alexluckett
left a comment
There was a problem hiding this comment.
really nice work, jez!
mokhld
reviewed
Nov 27, 2025
mokhld
reviewed
Nov 27, 2025
mokhld
reviewed
Nov 27, 2025
mokhld
reviewed
Nov 27, 2025
| await cacheService.setConfirmationState(request, { confirmed: true }) | ||
| await cacheService.setConfirmationState(request, { | ||
| confirmed: true, | ||
| formId: context.state.formId as string | undefined |
Contributor
There was a problem hiding this comment.
Should we not fix the type definition in FormSubmissionState?
Contributor
Author
There was a problem hiding this comment.
It's not part of that, and isn't typed, but I could add a FormConfirmationState type and reference that
mokhld
reviewed
Nov 27, 2025
mokhld
approved these changes
Nov 27, 2025
alexluckett
approved these changes
Nov 27, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Prepopulates URL params into state (where a hidden field with the same name has been defined in the form)
This PR goes hand-in-hand with forms-runner PR DEFRA/forms-runner#1008
Jira ticket: DF-553
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).