Feat/df 553 - CSAT feedback changes (in addition to forms-engine-plugin changes)#1008
Merged
jbarnsley10 merged 13 commits intomainfrom Dec 2, 2025
Merged
Feat/df 553 - CSAT feedback changes (in addition to forms-engine-plugin changes)#1008jbarnsley10 merged 13 commits intomainfrom
jbarnsley10 merged 13 commits intomainfrom
Conversation
This was referenced Nov 25, 2025
Added journey tests
alexluckett
reviewed
Nov 28, 2025
alexluckett
approved these changes
Dec 2, 2025
Contributor
alexluckett
left a comment
alexluckett
left a comment
There was a problem hiding this comment.
Great stuff Jez, thanks for the changes 👍 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket DF-553
Uses some functionality in forms-engine-plugin to handle CSAT feedback, using a custom controller FeedbackPageController in this codebase.
Removed legacy "feedback" property/schema from FormDefinition.
Please note - I have kept the final submission processing as-is but have tailored the confirmation.html to display appropriate info in a feedback submission. It seemed overkill to override the Status controller and submision process specifically for feedback forms.