Crash on dfhack trying to create an announcement

[typetetris]

Seems like it crashes, when it tries to create an annoucement for autonestbox.

crashlog

Dwarf Fortress Linux has crashed!
Dwarf Fortress Version 53.13
DFHack Version 53.13-r1

Signal SIGABRT
0> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x419c0) [0x7bac522419c0]
1> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x9caac) [0x7bac5229caac]
2> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x1e) [0x7bac5224190e]
3> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(abort+0xdf) [0x7bac52228942]
4> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x299c3) [0x7bac522299c3]
5> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0xa7565) [0x7bac522a7565]
6> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0xa778c) [0x7bac522a778c]
7> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(__libc_free+0xd0) [0x7bac522ac440]
8> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack3Gui16makeAnnouncementEN2df5enums17announcement_type17announcement_typeENS1_18announcement_flagsENS1_5coordENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEib+0x294) [0x7bac150fef14]
9> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack3Gui16showAnnouncementENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEib+0xb0) [0x7bac150ff6d0]
10> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/plugins/autonestbox.plug.so(+0xa751) [0x7bac15666751]
11> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/plugins/autonestbox.plug.so(plugin_onupdate+0x31) [0x7bac156679e1]
12> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack13PluginManager8OnUpdateERNS_13color_ostreamE+0x11d) [0x7bac14edff0d]
13> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack4Core8onUpdateERNS_13color_ostreamE+0x78) [0x7bac14d886e8]
14> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack4Core8doUpdateERNS_13color_ostreamE+0x268) [0x7bac14d91b78]
15> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress 2346660/hack/libdfhack.so(_ZN6DFHack4Core6UpdateEv+0x140) [0x7bac14d94f00]
16> ./libdfhooks.so(+0x33ae) [0x7bac4df753ae]
17> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress/libg_src_lib.so(_ZN9enablerst10async_loopEv+0x3b8) [0x7bac52eb8ff8]
18> /home/typetetris/.local/share/Steam/steamapps/common/Dwarf Fortress/libg_src_lib.so(_Z9call_loopPv+0x14) [0x7bac52eb9814]
19> /lib/x86_64-linux-gnu/libSDL2-2.0.so.0(+0x9d8d5) [0x7bac52af58d5]
20> /lib/x86_64-linux-gnu/libSDL2-2.0.so.0(+0x136ae9) [0x7bac52b8eae9]
21> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x9a97a) [0x7bac5229a97a]
22> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x122d2c) [0x7bac52322d2c]

• stderr
• savegame

[Bumber64]

The announcement changes definitely broke something.

I wonder if we should be using showAnnouncement here to begin with. Presumably we have better ways to communicate issues. Either gui/notify or one of our own message boxes that come with the DFHack label in the corner.

[ab9rf]

Appears to be the same issue report as this one from Steam. Copying the traceback here for reference:

Dwarf Fortress Linux has crashed!
Dwarf Fortress Version 53.13
DFHack Version 53.13-r1

Signal SIGABRT
0> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x44190) [0x7f8bd2917190]
1> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(pthread_kill+0x111) [0x7f8bd29707a1]
2> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x12) [0x7f8bd2917092]
3> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(abort+0x12) [0x7f8bd28fbed2]
4> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x29ea6) [0x7f8bd28fcea6]
5> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0xa7255) [0x7f8bd297a255]
6> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0xa7271) [0x7f8bd297a271]
7> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack3Gui16makeAnnouncementEN2df5enums17announcement_type17announcement_typeENS1_18announcement_flagsENS1_5coordENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEib+0x294) [0x7f8bb6aa9f14]
8> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack3Gui16showAnnouncementENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEib+0xb0) [0x7f8bb6aaa6d0]
9> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/plugins/autonestbox.plug.so(+0x9eaf) [0x7f8bb5504eaf]
10> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/plugins/autonestbox.plug.so(plugin_onupdate+0x31) [0x7f8bb55069e1]
11> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack13PluginManager8OnUpdateERNS_13color_ostreamE+0x11d) [0x7f8bb688af0d]
12> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack4Core8onUpdateERNS_13color_ostreamE+0x78) [0x7f8bb67336e8]
13> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack4Core8doUpdateERNS_13color_ostreamE+0x268) [0x7f8bb673cb78]
14> /home/higuita/Steam/steamapps/common/Dwarf Fortress/hack/libdfhack.so(_ZN6DFHack4Core6UpdateEv+0x140) [0x7f8bb673ff00]
15> ./libdfhooks.so(+0x33ae) [0x7f8bcd8a63ae]
16> /home/higuita/Steam/steamapps/common/Dwarf Fortress/libg_src_lib.so(_ZN9enablerst10async_loopEv+0x3b8) [0x7f8bd338bff8]
17> /home/higuita/Steam/steamapps/common/Dwarf Fortress/libg_src_lib.so(_Z9call_loopPv+0x14) [0x7f8bd338c814]
18> /lib/x86_64-linux-gnu/libSDL2-2.0.so.0(+0x9d8d5) [0x7f8bd2fc08d5]
19> /lib/x86_64-linux-gnu/libSDL2-2.0.so.0(+0x136ae9) [0x7f8bd3059ae9]
20> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x9b935) [0x7f8bd296e935]
21> /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/libc.so.6(+0x125d68) [0x7f8bd29f8d68]

[quietust]

Our Gui::makeAnnouncement function contains logic to delete excess reports beyond the currently defined MAX_REPORTS_SIZE (which we incidentally never increased from 3000 to 10000), and deleting reports is no longer safe (because the objects are members of an object_pool).