add ItemTraitsDialog to materials.lua#2199
Merged
myk002 merged 3 commits intoDFHack:developfrom Jun 12, 2022
Merged
Conversation
myk002
approved these changes
Jun 10, 2022
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
looks good, though since you can select multiple traits, I'd prefer ItemTraitsDialog instead of ItemTraitDialog.
Member
|
It's worth adding this to the "Lua" section in the changelog, too. |
TimurKelman
changed the title
ItemTraitDialog to materials.luaItemTraitsDialog to materials.lua
Contributor
Author
|
pluralized the name and added an entry to the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the dialog allows editing of item traits (where "item" is part of a job or work order or similar).
the list is the same as in vanilla work order conditions
tchange traits (but ordered differently).example usage:
gui/workorder-details.luafrom DFHack/scripts#358