add type identity for std::filesystem::path
#5309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should not be required, but `luaL_error` is not marked `[[noreturn]]` even though it reliably does not return, and i don't want to alter the lua module any more than absolutely necessary, so we do this here instead
myk002
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a type identity for
std::filesystem::path, which is expected to be used in the upcoming experimental DF release and thus needs to be supported by the type identity systemThis does not add support for paths to codegen; that needs to be done separately
The type added is not opaque; paths will be converting to Lua strings in UTF-8 encoding, and a Lua string will be converted to a path assuming UTF-8 encoding. Note that it is the developer's responsibility to convert CP437 to UTF-8, if necessary. Do not use CP-1252 or UCS-2 (wide) encoding, even on Windows; the type wrapper will take care of converting UTF-8 to UCS-2 on Windows platforms.