Logcleaner: Properly delete announcements#5726
Open
Bumber64 wants to merge 1 commit intoDFHack:developfrom
Open
Logcleaner: Properly delete announcements#5726Bumber64 wants to merge 1 commit intoDFHack:developfrom
Bumber64 wants to merge 1 commit intoDFHack:developfrom
Conversation
Contributor
Author
|
Seems to be removing announcements properly. I noticed that the plugin removes every single unit report the instant it's enabled, even while paused. I think the "ticks" its counting are actually frames. You'll never read a single sparring report as long as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deleted reports from the announcement vector to prevent dangling pointers.
I haven't tested this code. It's an emergency fix before the update goes out.